Pyarrow filter pushdowns#735
Merged
Merged
Conversation
The conversion was incorrectly passing in the expression itself as the `nan_as_null` argument. This caused the pushdown to silently fail.
andygrove
approved these changes
Jun 19, 2024
andygrove
left a comment
andygrove
left a comment
Member
There was a problem hiding this comment.
LGTM. Checking the explain plan is a good approach IMO. We do this extensively in DataFusion and Comet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #703.
Rationale for this change
The conversion for
IsNullhad a bug.datafusion-pythonusers requestedpyarrowpredicate pushdown support for temporal types.What changes are included in this PR?
IsNullbugThe conversion was incorrectly passing the
column-expressionas an argument to thepyarrowmethodis_null. This would silently fail and the predicate would be excluded from the plan.The argument should be a scalar for
nan_is_null. I do not currently have a way for users to pass that in, so please suggest how I might do so.Temporal Scalars
Similar to #731, I used
ScalarValue::to_pyarrowfor the scalar conversion.pyarrowfilters can now accept anything that already has an upstream conversion.Are there any user-facing changes?
A bugfix and expanded functionality.
Additional Context
I tested the predicate pushdown in two separate ways.
explainplan contains the appropriate string.Both of these seem non-ideal. If you have a suggestion for more efficiently testing this, please share!