Skip to content

Add support for LANGUAGE clause in CREATE PROCEDURE#1903

Merged
iffyio merged 4 commits into
apache:mainfrom
ZacJW:support-procedure-language
Jun 27, 2025
Merged

Add support for LANGUAGE clause in CREATE PROCEDURE#1903
iffyio merged 4 commits into
apache:mainfrom
ZacJW:support-procedure-language

Conversation

@ZacJW

@ZacJW ZacJW commented Jun 22, 2025

Copy link
Copy Markdown
Contributor

sqlparser-rs doesn't currently support the LANGUAGE clause in CREATE PROCEDURE (see grammar). This PR adds support for it.

Looks like the 'routine characteristics' clause isn't supported at all. I'll probably write separate PRs for those at some point.

@ZacJW ZacJW marked this pull request as ready for review June 22, 2025 11:53

@iffyio iffyio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ZacJW! The changes look good to me! could you take a look at the conflicts on the branch?

@ZacJW

ZacJW commented Jun 24, 2025

Copy link
Copy Markdown
Contributor Author

Was caused by both this PR and #1901 adding a test at the end of the same file. Fixed now

@iffyio iffyio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ZacJW!
cc @alamb

@iffyio iffyio changed the title Add support for LANGUAGE clause in CREATE PROCEDURE Add support for LANGUAGE clause in CREATE PROCEDURE Jun 27, 2025
@iffyio iffyio merged commit 95d16e3 into apache:main Jun 27, 2025
10 checks passed
@alamb

alamb commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

🚀

ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants