PostgreSQL: ALTER USER password option #2142
Merged
+63
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Jan 9, 2026
| /// ALTER USER [ IF EXISTS ] [ <name> ] [ OPTIONS ] | ||
| /// ``` | ||
| /// | ||
| /// [Snowflake](https://docs.snowflake.com/en/sql-reference/sql/alter-user) |
Contributor
There was a problem hiding this comment.
It seems we dropped this doc reference, could we add it back together with the new pg reference?
| } | ||
| verified_stmt("ALTER USER u1 SET DEFAULT_SECONDARY_ROLES=('ALL'), PASSWORD='secret', WORKLOAD_IDENTITY=(TYPE=AWS, ARN='arn:aws:iam::123456789:r1/')"); | ||
|
|
||
| verified_stmt("ALTER USER u1 PASSWORD 'AAA'"); |
Contributor
There was a problem hiding this comment.
can we add test cases for ENCRYPTED and PASSWORD NULL?
src/parser/alter.rs
Outdated
Comment on lines
298
to
309
| if self.parse_keyword(Keyword::NULL) { | ||
| Some(AlterUserPassword { | ||
| encrypted, | ||
| password: None, | ||
| }) | ||
| } else { | ||
| let password = self.parse_literal_string()?; | ||
| Some(AlterUserPassword { | ||
| encrypted, | ||
| password: Some(password), | ||
| }) | ||
| } |
Contributor
There was a problem hiding this comment.
minor probably to clarify the code, we could do e.g.
let password = if self.parse_keyword(Keyword::NULL) {
None
} else {
Some(self.parse_literal_string()?)
};
Some(AlterUserPassword {
encrypted,
password,
})
yoavcloud
force-pushed
the
pg_alter_user_password
branch
from
4d6ec1f to
cbbd106
Compare
yoavcloud
force-pushed
the
pg_alter_user_password
branch
from
cbbd106 to
9df7e3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.