Skip to content

Support for ClickHouse array types (e.g. [1,2,3])#429

Merged
alamb merged 1 commit into
apache:mainfrom
monadbobo:clickhouse
Mar 8, 2022
Merged

Support for ClickHouse array types (e.g. [1,2,3])#429
alamb merged 1 commit into
apache:mainfrom
monadbobo:clickhouse

Conversation

@monadbobo

Copy link
Copy Markdown
Contributor

No description provided.

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1941599389

  • 23 of 24 (95.83%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 90.567%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 5 6 83.33%
Totals Coverage Status
Change from base Build 1916566413: 0.02%
Covered Lines: 7191
Relevant Lines: 7940

💛 - Coveralls

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @monadbobo

Comment thread tests/sqpparser_clickhouse.rs
@alamb

alamb commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

FYI I hope to make the 0.15.0 release in the next day or two, so hopefully we can get this PR in for that release;

@alamb alamb merged commit 3f56194 into apache:main Mar 8, 2022
@alamb

alamb commented Mar 8, 2022

Copy link
Copy Markdown
Contributor

🤔 this change seems to have broken a downstream test in DataFusion : apache/datafusion#1956

In particular, sqlparser now rejects

SELECT array(c1, cast(c2 as varchar)) FROM test

As invalid (in this case array is a function name). I'll see if I can get a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants