Skip to content

join_inner_two, join_inner_one_two_parts_left and join_inner_one_two_parts_right fail with force_hash_collisions #11658

@alamb

Description

@alamb

Describe the bug

The force_hash_collisions feature flag is intended to ensure DataFusion works correctly even in the very unlikely event that hash values collide.

The new version of clippy in Rust 1.80 found we had not been running some tests with this flag #11651

And it turns out when we started running the tests with the hash collision they failed

we commented them out in #11654 but we should really figure out why they failed

Maybe the test needs to be updated or maybe there is a real bug

To Reproduce

Remove these lines from the tests mentioned above

    #[cfg(not(feature = "force_hash_collisions"))]

Then run

cargo test -p datafusion-physical-plan --features=force_hash_collisions

Expected behavior

Tests should pass

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinghelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions