Skip to content

equijoin_full_and_condition_from_both slt test fails with force_hash_collisions #11659

@alamb

Description

@alamb

Describe the bug

The force_hash_collisions feature flag is intended to ensure DataFusion works correctly even in the very unlikely event that hash values collide.

The new version of clippy in Rust 1.80 found we had not been running some tests with this flag #11651

And it turns out when we started running the tests with the hash collision they failed

we commented them out in #11654 but we should really figure out why they failed

Maybe the test needs to be updated or maybe there is a real bug

To Reproduce

Uncomment the equijoin_full_and_condition_from_both in datafusion/sqllogictest/test_files/sort_merge_join.slt and run it like

cargo test --test sqllogictests --features=force_hash_collisions -- sort_merge_join

Expected behavior

Test should pass

cargo test --test sqllogictests --features=force_hash_collisions

and

cargo test --test sqllogictests --features=force_hash_collisions -- sort_merge_join

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions