-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Description
I think rust_example.sh needs to be fixed to run the examples in this new format.
Originally posted by @Jefffrey in #18289 (review)
Specifcally, as @cj-zhukov has updated the examples we are likely no longer actually execute them as part of CI:
datafusion/ci/scripts/rust_example.sh
Lines 31 to 35 in 32d2618
| example_name=`basename $filename ".rs"` | |
| # Skip tests that rely on external storage and flight | |
| if [ ! -d $filename ]; then | |
| cargo run --profile ci --example $example_name | |
| fi |
Maybe something like add an ExampleKind::All type to the examples and then pass in all as an argument 🤔
Metadata
Metadata
Assignees
Labels
No labels