Skip to content

Support more types for approx_distinct function #22989

@2010YOUY01

Description

@2010YOUY01

Is your feature request related to a problem or challenge?

#22921 has refactored approx_distinct into a more generic implementation over different input types, now it's easy to support additional arg types. (Thanks to @Jefffrey for pointing it out in the review)

Describe the solution you'd like

  1. Identify the unsupported types
  2. Plan them into the generic implementation of Accumulator and GroupsAccumulator (see refactor: Simplify approx_distinct (-200 LoC) #22921 for details)
  3. Add sqllogictests

Note we don't have to support all applicable types at once, some complex type might get tricky to test, so I prefer to do this incrementally

Describe alternatives you've considered

No response

Additional context

No response

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request
No fields configured for Feature.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions