Skip to content

Add SessionStateBuilder and extract out the registration of defaults #11403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 10 commits into from
Jul 14, 2024
Merged

Add SessionStateBuilder and extract out the registration of defaults #11403

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fab06da
Create a SessionStateBuilder and use it for creating anything but a b…
Omega359 Jul 10, 2024
de39082
Updated new_from_existing to take a reference to the existing Session…
Omega359 Jul 10, 2024
7d1bc09
Minor documentation update.
Omega359 Jul 10, 2024
490214d
SessionStateDefaults improvements.
Omega359 Jul 10, 2024
93a3a7d
Merge branch 'apache:main' into feature/11320_session_state_builder
Omega359 Jul 10, 2024
e3fad6d
Reworked how SessionStateBuilder works from PR feedback.
Omega359 Jul 12, 2024
8a579cf
Bug fix for missing array_expressions cfg feature.
Omega359 Jul 12, 2024
eb64e2f
Merge remote-tracking branch 'refs/remotes/upstream/main' into featur…
Omega359 Jul 14, 2024
71decf6
Review feedback updates + doc fixes for SessionStateDefaults
Omega359 Jul 14, 2024
380ce98
Cargo fmt update.
Omega359 Jul 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bug fix for missing array_expressions cfg feature.
  • Loading branch information
@Omega359
Omega359 committed Jul 12, 2024
commit 8a579cf05d1696c932afd5e8bfc601d95a1097f0
3 changes: 2 additions & 1 deletion datafusion/core/src/execution/session_state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,7 @@ impl SessionStateBuilder {
}
}

/// Set defaults for table_factories, file formats, expr_planners and builtin
/// Set defaults for table_factories, file formats, expr_planners and builtin
Copy link
Contributor

@alamb alamb Jul 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great for this PR

As part of the larger catalog refactor, I think we'll ned to figure out how to get SessioNStateDefaults` out of this file -- but I have some ideas (specifically we can make the defaults a trait that could be passed to the builder).

Not for this PR

/// scalar and aggregate functions.
pub fn with_default_features(mut self) -> Self {
self.table_factories = Some(SessionStateDefaults::default_table_factories());
Expand Down Expand Up @@ -1478,6 +1478,7 @@ impl SessionStateDefaults {
/// returns a map of default [`ScalarUDF']'s keyed by name
pub fn default_scalar_functions() -> Vec<Arc<ScalarUDF>> {
let mut functions: Vec<Arc<ScalarUDF>> = functions::all_default_functions();
#[cfg(feature = "array_expressions")]
functions.append(&mut functions_array::all_default_array_functions());

functions
Expand Down