Parsing SQL strings to Exprs with the qualified schema #11562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optimizer
Contributor
|
I guess it will close #11551. How about modifying the description to link this issue? |
Contributor
Author
sure |
goldmedal
approved these changes
Jul 22, 2024
Contributor
goldmedal
left a comment
goldmedal
left a comment
There was a problem hiding this comment.
Thanks @Lordworms. LGTM
Comment on lines
55
to
61
| let is_unnamed_table = match &qualifier { | ||
| TableReference::Bare { table } => table.as_ref() == UNNAMED_TABLE, | ||
| TableReference::Partial { table, .. } => { | ||
| table.as_ref() == UNNAMED_TABLE | ||
| } | ||
| TableReference::Full { table, .. } => table.as_ref() == UNNAMED_TABLE, | ||
| }; |
alamb
changed the title
Contributor
|
Thanks @Lordworms and @goldmedal Since this changes the logic to resolve identifiers I think it should have a more careful review. Maybe @jonahgao has time. If not I will try and find time later this week |
Member
|
Thanks @Lordworms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11551
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?