Skip to content

feat(udf): POC faster min max accumulator #12677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devanbenz wants to merge 17 commits into from
Closed

feat(udf): POC faster min max accumulator #12677

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
571013d
feat: wip: working on it
devanbenz Sep 27, 2024
f7634e1
feat: working on it
devanbenz Sep 27, 2024
6d522fa
feat(udf): POC for native min max accumulators
devanbenz Sep 30, 2024
bd9ea7d
feat: revert some changes
devanbenz Sep 30, 2024
fe64903
feat: add BinaryView to groups accum supported
devanbenz Sep 30, 2024
fbdf867
feat: revert some changes while testing
devanbenz Sep 30, 2024
0a93803
feat: rename file
devanbenz Sep 30, 2024
4819521
chore: add license header
devanbenz Sep 30, 2024
6f048fd
feat: clippy + fmt + check
devanbenz Sep 30, 2024
1cefad5
chore: fmt
devanbenz Sep 30, 2024
a60d599
feat: fix max accum
devanbenz Sep 30, 2024
268aa91
chore: fix emit_to calls
devanbenz Sep 30, 2024
77b980f
fix: rm not needed import
devanbenz Sep 30, 2024
660eaa4
feat: moves all functionality to single primitive strings function
devanbenz Oct 3, 2024
7205cca
feat: rename to string_op
devanbenz Oct 3, 2024
a52cefe
fix: need to implement own accumulator
devanbenz Oct 3, 2024
a0a1572
fix: fmt
devanbenz Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: rm not needed import
  • Loading branch information
@devanbenz
devanbenz committed Sep 30, 2024
commit 77b980fedb8e7a0c20e16c715c3b0697907a28ed
1 change: 0 additions & 1 deletion datafusion/functions-aggregate-common/src/aggregate/min_max/groups_accumulator_min_view.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use std::os::macos::raw::stat;
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
Expand Down