-
Notifications
You must be signed in to change notification settings - Fork 2k
Implement special min/max accumulator for Strings and Binary (10% faster for Clickbench Q28) #12792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
8bc00f8
Implement special min/max accumulator for Strings: `MinMaxBytesAccumu…
alamb 19b3297
fix bug
alamb 4b3e625
fix msrv
alamb 64e9861
move code, handle filters
alamb c4f6271
simplify
alamb c3145cd
Merge remote-tracking branch 'apache/main' into alamb/min_max_strings
alamb 126a9a8
Add functional tests
alamb a7ebb56
remove unecessary test
alamb 2d5957d
improve docs
alamb 2671b2d
improve docs
alamb a43288e
Merge remote-tracking branch 'apache/main' into alamb/min_max_strings
alamb 043ac35
cleanup
alamb e454838
improve comments
alamb 8618673
Merge remote-tracking branch 'apache/main' into alamb/min_max_strings
alamb c7aa11f
fix diagram
alamb 8e876bf
fix accounting
alamb 1389fb7
Use correct type in memory accounting
alamb 558e1ba
Merge remote-tracking branch 'apache/main' into alamb/min_max_strings
alamb 7853d8f
Add TODO comment
alamb 81431a0
Merge remote-tracking branch 'apache/main' into alamb/min_max_strings
alamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix msrv
- Loading branch information
commit 4b3e625ff2472a9913ab6da6efaec5ca2dd93ac8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.