Skip to content

Conversation

@niebayes
Copy link
Contributor

Which issue does this PR close?

Closes #13375.

Rationale for this change

What changes are included in this PR?

  • Expose TypeCoercionRewriter::new.
  • Add examples for applying type coercion to expressions.
  • Update out-of-date README for the datafusion-sql module

Are these changes tested?

Are there any user-facing changes?

The TypeCoercionRewriter::new is now made public.

@github-actions github-actions bot added sql SQL Planner optimizer Optimizer rules labels Nov 13, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @niebayes -- this looks really nice ❤️

Very well done on the examples. I left some small suggestions but nothing that I think is required. Again 👏

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@niebayes
Copy link
Contributor Author

@alamb Thanks for reviewing so quickly. I have submitted the changes.

Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @niebayes @alamb

@jonahgao jonahgao merged commit f35ab75 into apache:main Nov 14, 2024
@niebayes niebayes deleted the chore/expose_type_coercion_rewriter branch November 14, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optimizer Optimizer rules sql SQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose TypeCoercionRewriter::new

3 participants