Skip to content

Fix the duplicate short options in tpch#1424

Merged
alamb merged 1 commit into
apache:masterfrom
silathdiir:fix-duplicate-short-opts-in-tcph
Dec 9, 2021
Merged

Fix the duplicate short options in tpch#1424
alamb merged 1 commit into
apache:masterfrom
silathdiir:fix-duplicate-short-opts-in-tcph

Conversation

@silathdiir

@silathdiir silathdiir commented Dec 9, 2021

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #1409 .

Rationale for this change

The crash of command cargo run --bin tpch is caused by the duplicate short names of option path and partitions.
It seems that the short name of partitions is updated from n to p in the PR-706.
There is an associating issue-500 of structopt.

What changes are included in this PR?

Reverts the short name of partitions from p to n.

Are there any user-facing changes?

Seems no.

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @silathdiir

@alamb alamb merged commit 7996fa8 into apache:master Dec 9, 2021
@houqp houqp added the bug Something isn't working label Dec 10, 2021
unkloud pushed a commit to unkloud/datafusion that referenced this pull request Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cargo run --bin tpch fails with thread 'main' panicked at 'Argument short must be unique -p is already in use'

3 participants