Skip to content

fix: The inconsistency between scalar and array on the cast decimal to timestamp #16539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 6 commits into from
Jul 18, 2025
Merged

fix: The inconsistency between scalar and array on the cast decimal to timestamp #16539

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
327530b
fix: The inconsistency between scalar and array on the cast of timestamp
chenkovsky Jun 24, 2025
1810f7d
fix for timeunit
chenkovsky Jun 25, 2025
92f26f1
fmt
chenkovsky Jun 25, 2025
d89f0f9
add slt
chenkovsky Jun 26, 2025
0b084f3
update based on findepi's suggestion
chenkovsky Jul 18, 2025
51ba6e2
Merge branch 'main' into fix/timestamp
chenkovsky Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add slt
  • Loading branch information
@chenkovsky
chenkovsky committed Jun 26, 2025
commit d89f0f974cf6db3cd730de14a720df7f6c91a333
29 changes: 29 additions & 0 deletions datafusion/sqllogictest/test_files/timestamps.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3455,3 +3455,32 @@ SELECT arrow_cast(CAST(one AS decimal(17,2)), 'Timestamp(Second, None)') AS a FR
----
1970-01-01T00:00:01
1970-01-01T00:00:01


query P
SELECT arrow_cast(CAST(1.123 AS decimal(17,3)), 'Timestamp(Nanosecond, None)') AS a UNION ALL
SELECT arrow_cast(CAST(one AS decimal(17,3)), 'Timestamp(Nanosecond, None)') AS a FROM (VALUES (1.123)) t(one);
----
1970-01-01T00:00:00.000000001
1970-01-01T00:00:00.000000001

query P
SELECT arrow_cast(CAST(1.123 AS decimal(17,3)), 'Timestamp(Microsecond, None)') AS a UNION ALL
SELECT arrow_cast(CAST(one AS decimal(17,3)), 'Timestamp(Microsecond, None)') AS a FROM (VALUES (1.123)) t(one);
----
1970-01-01T00:00:00.000001
1970-01-01T00:00:00.000001

query P
SELECT arrow_cast(CAST(1.123 AS decimal(17,3)), 'Timestamp(Millisecond, None)') AS a UNION ALL
SELECT arrow_cast(CAST(one AS decimal(17,3)), 'Timestamp(Millisecond, None)') AS a FROM (VALUES (1.123)) t(one);
----
1970-01-01T00:00:00.001
1970-01-01T00:00:00.001

query P
SELECT arrow_cast(CAST(1.123 AS decimal(17,3)), 'Timestamp(Second, None)') AS a UNION ALL
SELECT arrow_cast(CAST(one AS decimal(17,3)), 'Timestamp(Second, None)') AS a FROM (VALUES (1.123)) t(one);
----
1970-01-01T00:00:01
1970-01-01T00:00:01