Skip to content

disallow pushdown of volatile functions #16861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 5 commits into from
Jul 29, 2025
Merged

disallow pushdown of volatile functions #16861

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d03e5d6
dissallow pushdown of volatile PhysicalExprs
adriangb Jul 23, 2025
fa28c6d
fix
adriangb Jul 23, 2025
4c1b0e2
add FilteredVec helper to handle filter / remap pattern (#34)
adriangb Jul 28, 2025
ab34cac
lint
adriangb Jul 28, 2025
d63b3e7
Add slt test for pushing volatile predicates down (#35)
alamb Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@adriangb
adriangb committed Jul 28, 2025
commit ab34cacac19df7fcea113bbbeab73297a5a7ee07
4 changes: 2 additions & 2 deletions datafusion/physical-optimizer/src/filter_pushdown.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ fn push_down_filters(

// Add the filtered parent predicates to all_predicates
for filter in parent_filters_for_child.items() {
all_predicates.push(filter.predicate.clone());
all_predicates.push(Arc::clone(&filter.predicate));
}

let num_parent_filters = all_predicates.len() - num_self_filters;
Expand Down Expand Up @@ -572,7 +572,7 @@ fn push_down_filters(
// Update parent_filter_pushdown_supports with the mapped results
// mapped_parent_results already has the results at their original indices
for (idx, support) in parent_filter_pushdown_supports.iter_mut().enumerate() {
support[child_idx] = mapped_parent_results[idx].clone();
support[child_idx] = mapped_parent_results[idx];
}
}

Expand Down