[#21878] extensive test for multi-dictionary column group bys#22888
[#21878] extensive test for multi-dictionary column group bys#22888Rich-T-kid wants to merge 3 commits into
Conversation
777a7d5 to
a6c003c
Compare
|
I tried to make each test function as declarative as possible. |
|
@2010YOUY01 I know you have a lot of experience with aggregation operator in datafusion . Do you mind taking a look at this smaller PR, when you get a chance? |
|
I don't have enough context on the dictionary type support right now, but this is pretty cool. I hope to find some time to look into it later. Here is a bit of context I can share: I assume we would need to specialize a TL;DR: today, |
|
Thx, I'll defiantly take a look at the issue when I get a chance! |
Which issue does this PR close?
works towards closing #21878. But also adds test coverage for existing code that wasnt there before. There were no test for dictionaries specifically for groupValueRows
Rationale for this change
There was a lack of test that focused on dictionary arrays in
GroupValueRows. I also would like to keep the test separate from the implementation (for #21878) so that its easier to review.What changes are included in this PR?
GroupValuesRowspath(Dict<Int8,Utf8>, Dict<Int32,LargeUtf8>, Dict<Int8,Utf8View>). these are the first SLT tests where the grouping keys themselves are dictionary columnsAre these changes tested?
The changes are test 😆
Are there any user-facing changes?
No