Rich t kid/implement multi dictionary aggr#22983
Draft
Rich-T-kid wants to merge 5 commits into
Draft
Conversation
Rich-T-kid
commented
Jun 17, 2026
Rich-T-kid
left a comment
Contributor
Author
There was a problem hiding this comment.
alot of minor things to clean up.
notably most of the logic here isn't too specific to dictionary arrays besides caching the values pointer. we need benchmarks to determine if this is worth approaching over a generic implementation like GroupValueRows
Rich-T-kid
commented
Jun 17, 2026
Contributor
Author
|
going through this now |
c6c4c5b to
d03f712
Compare
d03f712 to
ef4ba19
Compare
…for key-tuple cache
Contributor
Author
Still iterating on the PR, these are loose ideas for optimizations (intern path)use VecDeque instead of Vec
adjust the row-tuple cache to be configurable
avoid current double allocation spent for option
bitpack key-tuples cache
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?