Skip to content

Fix optimizer regression with simplifying expressions in subquery filters #3764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 5 commits into from
Oct 10, 2022
Merged

Fix optimizer regression with simplifying expressions in subquery filters #3764

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b011f3c
add failing test
andygrove Oct 7, 2022
c7cdc13
update tests
andygrove Oct 7, 2022
42502e0
document issue in test
andygrove Oct 7, 2022
28ad669
Merge remote-tracking branch 'apache/master' into fix-opt-regression
andygrove Oct 7, 2022
0ee1c83
fix merge conflict
andygrove Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add failing test
  • Loading branch information
@andygrove
andygrove committed Oct 7, 2022
commit b011f3c5725b632d3668084c02d4b43fd57013a2
20 changes: 20 additions & 0 deletions datafusion/optimizer/tests/integration-test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,26 @@ fn case_when() -> Result<()> {
Ok(())
}

#[test]
fn subquery_filter_with_cast() -> Result<()> {
let sql = "SELECT col_int32 FROM test \
WHERE col_int32 > (\
SELECT AVG(col_int32) FROM test \
WHERE col_utf8 BETWEEN '2002-05-08' \
AND (cast('2002-05-08' as date) + interval '5 days')\
)";
let plan = test_sql(sql)?;
let expected =
"Projection: test.col_int32\n Filter: CAST(test.col_int32 AS Float64) > __sq_1.__value\
\n CrossJoin:\n TableScan: test projection=[col_int32]\
\n Projection: AVG(test.col_int32) AS __value, alias=__sq_1\
\n Aggregate: groupBy=[[]], aggr=[[AVG(test.col_int32)]]\
\n Filter: test.col_utf8 BETWEEN Utf8(\"2002-05-08\") AND Utf8(\"2002-05-13\")\
\n TableScan: test projection=[col_int32, col_utf8]";
assert_eq!(expected, format!("{:?}", plan));
Ok(())
}

#[test]
fn case_when_aggregate() -> Result<()> {
let sql = "SELECT col_utf8, SUM(CASE WHEN col_int32 > 0 THEN 1 ELSE 0 END) AS n FROM test GROUP BY col_utf8";
Expand Down