Skip to content

Minor: Port tests in displayable.rs to sqllogictest#8246

Merged
alamb merged 2 commits into
apache:mainfrom
Weijun-H:chore
Nov 17, 2023
Merged

Minor: Port tests in displayable.rs to sqllogictest#8246
alamb merged 2 commits into
apache:mainfrom
Weijun-H:chore

Conversation

@Weijun-H

@Weijun-H Weijun-H commented Nov 17, 2023

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes #8198

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions Bot added the core Core DataFusion crate label Nov 17, 2023
Comment on lines -46 to -51
assert_eq!("CoalesceBatchesExec: target_batch_size=8192\
\n FilterExec: a@0 < 5\
\n RepartitionExec: partitioning=RoundRobinBatch(3), input_partitions=1\
\n CsvExec: file_groups={1 group: [[WORKING_DIR/tests/data/example.csv]]}, projection=[a], has_header=true",
plan_string.trim());

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@comphead comphead left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @Weijun-H

@alamb

alamb commented Nov 17, 2023

Copy link
Copy Markdown
Contributor

Thanks @Weijun-H and @comphead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port tests in describe.rs to sqllogictest

3 participants