[enhancement](decommission) speed up decommission process (#14028)#14006
Conversation
|
TeamCity pipeline, clickbench performance test result: |
dutyu
changed the title
|
|
||
| List<Long> backendTabletIds = invertedIndex.getTabletIdsByBackendId(beId); | ||
| if (backendTabletIds.isEmpty() && Config.drop_backend_after_decommission) { | ||
| if ((backendTabletIds.isEmpty() || Env.getCurrentRecycleBin().allTabletsInRecycledStatus(backendTabletIds)) |
There was a problem hiding this comment.
allTabletsInRecycledStatus is expensive, maybe we should put Config.drop_backend_after_decommission as the first condition.
There was a problem hiding this comment.
Appreciate for your suggestion, i have changed the code here.
There was a problem hiding this comment.
allTabletsInRecycledStatusis expensive, maybe we should putConfig.drop_backend_after_decommissionas the first condition.
Would be appreciate if you spend some time to review it again.
dutyu
force-pushed
the
enhance_decommission
branch
from
a471d2a to
a55f50a
Compare
|
PR approved by at least one committer and no changes requested. |
github-actions
Bot
added
approved
|
PR approved by anyone and no changes requested. |
| idToRecycleTime = Maps.newHashMap(); | ||
| } | ||
|
|
||
| public synchronized boolean allTabletsInRecycledStatus(List<Long> backendTabletIds) { |
There was a problem hiding this comment.
The backendTabletIds may contains millions of ids, which may cause a long run.
There was a problem hiding this comment.
Thanks, as we've just discussed, i will add a threshold to control this check and add some logs.
github-actions
Bot
removed
the
approved
dutyu
requested review from
cambyzju,
hf200012 and
morningman
and removed request for
cambyzju,
hf200012 and
morningman
github-actions
Bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
5 participants
Proposed changes
Issue Number: close #14028
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...