[Feature](map) add map type to doris#15966
Merged
Merged
Conversation
github-actions
Bot
added
area/planner
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+124
to
+125
| if (!keys->equals(*rhs_map.keys)) | ||
| return false; |
Contributor
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| if (!keys->equals(*rhs_map.keys)) | |
| return false; | |
| if (!keys->equals(*rhs_map.keys)) { | |
| return false; | |
| } |
Contributor
|
Please change the title and rebase the code |
xiaokang
reviewed
Jan 17, 2023
xiaokang
reviewed
Jan 17, 2023
xiaokang
reviewed
Jan 17, 2023
xiaokang
reviewed
Jan 17, 2023
xiaokang
reviewed
Jan 17, 2023
xy720
reviewed
Jan 17, 2023
xy720
reviewed
Jan 17, 2023
xy720
reviewed
Jan 18, 2023
amorynan
requested review from
xiaokang and
xy720
and removed request for
xiaokang
xy720
reviewed
Feb 1, 2023
| create_data_type(col_desc.children[1], col_desc.contains_nulls[1])); | ||
| break; | ||
| } | ||
| case INVALID_TYPE: |
Contributor
There was a problem hiding this comment.
warning: 'case' statement not in switch statement [clang-diagnostic-error]
case INVALID_TYPE:
^| for (int i = 0; i < _children.size(); ++i) { | ||
| if (!_children[i]->is_constant()) { | ||
| return false; | ||
| std::string VExpr::debug_string(const std::vector<VExprContext*>& ctxs) { |
Contributor
There was a problem hiding this comment.
warning: function definition is not allowed here [clang-diagnostic-error]
std::string VExpr::debug_string(const std::vector<VExprContext*>& ctxs) {
^|
|
||
| return true; | ||
| } | ||
| bool VExpr::is_constant() const { |
Contributor
There was a problem hiding this comment.
warning: function definition is not allowed here [clang-diagnostic-error]
bool VExpr::is_constant() const {
^| } | ||
|
|
||
| if (_constant_col != nullptr) { | ||
| Status VExpr::get_const_col(VExprContext * context, ColumnPtrWrapper * *output) { |
Contributor
There was a problem hiding this comment.
warning: function definition is not allowed here [clang-diagnostic-error]
Status VExpr::get_const_col(VExprContext * context, ColumnPtrWrapper * *output) {
^
xy720
reviewed
Feb 2, 2023
| return Status::OK(); | ||
| } | ||
|
|
||
| Status VExpr::create_tree_from_thrift(doris::ObjectPool* pool, |
Contributor
Author
There was a problem hiding this comment.
when I use clang-format.sh , it make these change...
added 2 commits
February 2, 2023 15:51
This reverts commit 817e0ab.
amorynan
changed the title
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
amorynan
requested review from
xy720
and removed request for
xiaokang and
xy720
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
TO support doris complex type for map
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...