Skip to content

[feature](cooldown)add ut for cooldown on be#17246

Merged
pengxiangyu merged 37 commits into
apache:masterfrom
pengxiangyu:add_be_ut
Mar 7, 2023
Merged

[feature](cooldown)add ut for cooldown on be#17246
pengxiangyu merged 37 commits into
apache:masterfrom
pengxiangyu:add_be_ut

Conversation

@pengxiangyu

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@pengxiangyu pengxiangyu marked this pull request as draft February 28, 2023 11:41

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread be/test/io/fs/remote_file_system_mock.cpp Outdated
Comment thread be/test/io/fs/remote_file_system_mock.cpp Outdated
Comment thread be/test/io/fs/remote_file_system_mock.cpp Outdated
Comment thread be/test/io/fs/remote_file_system_mock.cpp Outdated
Comment thread be/test/io/fs/remote_file_system_mock.cpp Outdated
Comment thread be/test/io/fs/remote_file_system_mock.cpp Outdated
Comment thread be/test/io/fs/remote_file_system_mock.cpp Outdated
Comment thread be/test/io/fs/remote_file_system_mock.h Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp
Comment thread be/test/olap/tablet_cooldown_test.cpp
Comment thread be/test/olap/tablet_cooldown_test.cpp
Comment thread be/test/olap/tablet_cooldown_test.cpp
Comment thread be/test/olap/tablet_cooldown_test.cpp
Comment thread be/test/olap/tablet_cooldown_test.cpp
Comment thread be/test/olap/tablet_cooldown_test.cpp
Comment thread be/test/olap/tablet_cooldown_test.cpp

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread be/test/olap/tablet_cooldown_test.cpp

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread be/test/olap/tablet_cooldown_test.cpp

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread be/test/olap/tablet_cooldown_test.cpp
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread be/test/olap/tablet_cooldown_test.cpp
Comment thread be/test/olap/tablet_cooldown_test.cpp
Comment thread be/test/olap/tablet_cooldown_test.cpp
Comment thread be/test/olap/tablet_cooldown_test.cpp
Comment thread be/test/olap/tablet_cooldown_test.cpp
Comment thread be/test/olap/tablet_cooldown_test.cpp
Comment thread be/test/olap/tablet_cooldown_test.cpp
Comment thread be/test/olap/tablet_cooldown_test.cpp
Comment thread be/test/olap/tablet_cooldown_test.cpp
Comment thread be/test/olap/tablet_cooldown_test.cpp

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread be/test/olap/tablet_cooldown_test.cpp
@github-actions

github-actions Bot commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actions Bot commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actions Bot commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

github-actions Bot commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
Comment thread be/test/olap/tablet_cooldown_test.cpp Outdated
@github-actions

github-actions Bot commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actions Bot commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

github-actions Bot commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actions Bot commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@pengxiangyu

Copy link
Copy Markdown
Contributor Author

run buildall

@pengxiangyu

Copy link
Copy Markdown
Contributor Author

run compile

@adonis0147 adonis0147 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Mar 7, 2023
@github-actions

github-actions Bot commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actions Bot commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@pengxiangyu pengxiangyu merged commit e94170d into apache:master Mar 7, 2023
@pengxiangyu pengxiangyu deleted the add_be_ut branch March 7, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants