[fix](expr) avoid crashing caused by big depth of expression tree#17314
Merged
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
yiguolei
reviewed
Mar 2, 2023
| int max_child_depth = 0; | ||
| for (int i = 0; i < _children.size(); ++i) { | ||
| RETURN_IF_ERROR(_children[i]->prepare(state, row_desc, context)); | ||
| if ((context->_depth_num - old_depth) > max_child_depth) { |
Contributor
There was a problem hiding this comment.
--context->_depth_num is OK?
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
./run buildall |
Contributor
|
PR approved by anyone and no changes requested. |
5 tasks
morningman
pushed a commit
that referenced
this pull request
Mar 2, 2023
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 9, 2023
This was referenced Mar 27, 2023
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When the tree is too deep, too many recursive calls will cause stack overflow.
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...