Skip to content

Bug-fix: Enable StringLiteral cast to Varchar#1846

Merged
imay merged 1 commit into
apache:masterfrom
EmmyMiao87:stringliteral_cast_bug
Sep 23, 2019
Merged

Bug-fix: Enable StringLiteral cast to Varchar#1846
imay merged 1 commit into
apache:masterfrom
EmmyMiao87:stringliteral_cast_bug

Conversation

@EmmyMiao87

Copy link
Copy Markdown
Contributor

For issue: #1842
StringLiteral could be cast to VARCHAR or CHAR.
The default value of lead and lag function could be 'String' when the column type is CHAR or VARCHAR.

@EmmyMiao87 EmmyMiao87 added kind/fix Categorizes issue or PR as related to a bug. SQL Bug labels Sep 23, 2019
@EmmyMiao87 EmmyMiao87 requested a review from imay September 23, 2019 07:00
imay
imay previously approved these changes Sep 23, 2019
For issue: apache#1842
StringLiteral could be cast to VARCHAR or CHAR.
The default value of lead and lag function could be 'String' when the column type is CHAR or VARCHAR.

@imay imay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay merged commit fded13e into apache:master Sep 23, 2019
@imay imay mentioned this pull request Sep 26, 2019
swjtu-zhanglei pushed a commit to swjtu-zhanglei/incubator-doris that referenced this pull request Jul 25, 2023
After selectdb/selectdb-core#1697, `DeltaWriter::init` will be called in bthread stack, and
`DeltaWriter::init` may call `Tablet::prepare_compaction_and_calculate_permits` when there are too many rowsets in tablet, must not use thread local based `Trace` in bthread.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants