Skip to content

Take segments in singleton rowset into consideration upon cumulative compaction#1866

Merged
chaoyli merged 1 commit into
apache:masterfrom
chaoyli:master
Sep 25, 2019
Merged

Take segments in singleton rowset into consideration upon cumulative compaction#1866
chaoyli merged 1 commit into
apache:masterfrom
chaoyli:master

Conversation

@chaoyli

@chaoyli chaoyli commented Sep 25, 2019

Copy link
Copy Markdown
Contributor

In previous compaction, only rowsets will be taken into consideration.
Doing streaming load, the singleton rowset may be made up of many overlapping segments.
Scanning these overlapping segments will result in read amplification.
To address this problem, overlapping segments should be taken into consideration
when doing cumulative compaction to reduce read amplification.

…compaction

In previous compaction, only rowsets will be taken into consideration.
Doing streaming load, the singleton rowset may is made up of many overlapping segments.
Scanning these overlapping segments will result in read amplification.
To address this problem, overlapping segments should be taken into consideration
when doing cumulative compaction to reduce read amplification.

@imay imay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaoyli

chaoyli commented Sep 25, 2019

Copy link
Copy Markdown
Contributor Author

related issue is #1867

@chaoyli chaoyli merged commit 09482c9 into apache:master Sep 25, 2019
@imay imay mentioned this pull request Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants