Skip to content

[feature](mtmv)disable mtmv for 2.0#26176

Merged
xiaokang merged 2 commits into
apache:branch-2.0from
zddr:disable_mtmv_2.0
Nov 1, 2023
Merged

[feature](mtmv)disable mtmv for 2.0#26176
xiaokang merged 2 commits into
apache:branch-2.0from
zddr:disable_mtmv_2.0

Conversation

@zddr

@zddr zddr commented Oct 31, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

disable mtmv for 2.0

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions Bot added the area/planner Issues or PRs related to the query planner label Oct 31, 2023
@zddr

zddr commented Oct 31, 2023

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.42 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17167451930 Bytes

@zddr

zddr commented Oct 31, 2023

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.66 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17164271934 Bytes

@xiaokang xiaokang merged commit 683b4ef into apache:branch-2.0 Nov 1, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
@zddr zddr deleted the disable_mtmv_2.0 branch March 28, 2024 02:35
englefly added a commit to englefly/incubator-doris that referenced this pull request Jun 16, 2026
…ry (apache#26176)

visitMapContainsKey/Value/Entry only visited the map argument
(getArgument(0)) and skipped the key/value/entry argument
(getArgument(1)). When the key is a nested sub-column expression
(e.g. element_at(s, 'a')) and the same sub-column also appears in
IS NULL, NestedColumnPruning would only see [s.a.NULL] and prune
the column to null-only metadata access.

Fix: after visiting the map argument, also visit the second argument
with a fresh context to register its data access paths.

Regression test map_contains_arg_pruning covers:
- map_contains_key with struct sub-column key + IS NULL
- map_contains_value with struct sub-column value + IS NULL
- Combined key + value sub-column access

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/planner Issues or PRs related to the query planner dev/2.0.3-merged kind/test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants