Skip to content

[compile](fix) fix gcc compile error #32583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shuke987 wants to merge 2 commits into from
Closed

[compile](fix) fix gcc compile error #32583

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a308e5
fix gcc compile error
shuke987 Mar 21, 2024
ecfaf5f
2
shuke987 Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion be/src/vec/aggregate_functions/aggregate_function_collect.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,7 @@ class AggregateFunctionCollect
Arena* arena, const size_t num_rows) const override {
if constexpr (ShowNull::value) {
for (size_t i = 0; i != num_rows; ++i) {
if (places[i] + offset) {
if (places[i] || offset) {

@cambyzju cambyzju Mar 21, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not change the logic while fix compile error.

offset is added from pr #32387, please have a review @amorynan

@shuke987 shuke987 Mar 21, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

place[i] is a pointer, and offset is an unsigned int, so if placces[i] != null or offset != 0, equals places[i] + offset != null

@cambyzju cambyzju Mar 21, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the correct answer is like: if(places[i] && offset < places[i].size()), check offset != 0 or == 0 is strange here.

@zclllyybb zclllyybb Mar 21, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here below we use places[i]+offset as an pointer. so maybe places[i] + offset != nullptr is correct and more readable

this->data(places[i] + offset)
.deserialize_and_merge(*assert_cast<const IColumn*>(column), i);
}
Expand Down