Skip to content

[fix](Nereids) AnalyzeTblStmt should fail when disabling fallback_to_original_planner #34532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhangbutao wants to merge 1 commit into from
Closed

[fix](Nereids) AnalyzeTblStmt should fail when disabling fallback_to_original_planner #34532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package org.apache.doris.qe;

import org.apache.doris.analysis.AnalyzeTblStmt;
import org.apache.doris.analysis.CreateTableAsSelectStmt;
import org.apache.doris.analysis.CreateTableStmt;
import org.apache.doris.analysis.DeleteStmt;
Expand Down Expand Up @@ -315,7 +316,8 @@ public void executeQuery(MysqlCommand mysqlCommand, String originStmt) throws Ex
|| s instanceof UpdateStmt
|| s instanceof DeleteStmt
|| s instanceof CreateTableAsSelectStmt
|| s instanceof CreateTableStmt)) {
|| s instanceof CreateTableStmt
|| s instanceof AnalyzeTblStmt)) {

@morrySnow morrySnow May 9, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

analyze table do not impl in Nereids, so should not failed even if disabling fallback_to_original_planner

@zhangbutao zhangbutao May 9, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. It just makes me confused that analyze table can be sucessful but actually it not be Implemented in Nereids.

set enable_nereids_planner=true;
set enable_fallback_to_original_planner=false;

@zhangbutao zhangbutao May 9, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, Should we impl analyze table in Neredis side in the future?

@morrySnow morrySnow May 9, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many statement has not been impl in Nereids.
All these statements will fall back to Legacy planner automaticly even if disable enable_fallback_to_original_planner

Should we impl analyze table in Neredis side in the future

Yes, We should impl ALL statement in Nereids in feature.

Feel free to impl them in Nereids if you're willing.😁

@zhangbutao zhangbutao May 9, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, i will try to impl partial statements in Nereids if i have any bandwidth. 😃
Thanks.

String errMsg;
Throwable exception = null;
if (nereidsParseException != null) {
Expand Down