Skip to content

[fix](move-memtable) change brpc connection type to single #34883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 4 commits into from
May 15, 2024
Merged

[fix](move-memtable) change brpc connection type to single #34883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99dec41
[fix](move-memtable) change brpc connection type to single
kaijchen May 14, 2024
1c56f99
connection_group = streaming
kaijchen May 15, 2024
4e13e15
style
kaijchen May 15, 2024
572d600
fix comment
kaijchen May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion be/src/util/brpc_client_cache.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ class BrpcClientCache {

std::shared_ptr<T> get_new_client_no_cache(const std::string& host_port,
const std::string& protocol = "baidu_std",
const std::string& connect_type = "") {
const std::string& connect_type = "",
const std::string& connection_group = "") {
brpc::ChannelOptions options;
if constexpr (std::is_same_v<T, PFunctionService_Stub>) {
options.protocol = config::function_service_protocol;
Expand All @@ -121,6 +122,9 @@ class BrpcClientCache {
if (connect_type != "") {
options.connection_type = connect_type;
}
if (connection_group != "") {
options.connection_group = connection_group;
}
options.connect_timeout_ms = 2000;
options.max_retry = 10;

Expand Down
6 changes: 3 additions & 3 deletions be/src/vec/sink/load_stream_stub.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,9 @@ Status LoadStreamStub::open(BrpcClientCache<PBackendService_Stub>* client_cache,
*request.add_tablets() = tablet;
}
POpenLoadStreamResponse response;
// use "pooled" connection to avoid conflicts between streaming rpc and regular rpc,
// see: https://github.com/apache/brpc/issues/392
const auto& stub = client_cache->get_new_client_no_cache(host_port, "baidu_std", "pooled");
// set connection_group "streaming" to distinguish with non-streaming connections
const auto& stub =
client_cache->get_new_client_no_cache(host_port, "baidu_std", "single", "streaming");
stub->open_load_stream(&cntl, &request, &response, nullptr);
for (const auto& resp : response.tablet_schemas()) {
auto tablet_schema = std::make_unique<TabletSchema>();
Expand Down