Skip to content

[Fix](variant) ignore serialization of nothing type#37006

Merged
morningman merged 1 commit into
apache:branch-2.1from
eldenmoon:pick-rg
Jun 28, 2024
Merged

[Fix](variant) ignore serialization of nothing type#37006
morningman merged 1 commit into
apache:branch-2.1from
eldenmoon:pick-rg

Conversation

@eldenmoon

@eldenmoon eldenmoon commented Jun 28, 2024

Copy link
Copy Markdown
Member

picked from #36997

1. fix variant should not serialize nothing type
2. fix unstable cases
@doris-robot

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@eldenmoon

Copy link
Copy Markdown
Member Author

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.32% (9144/25174)
Line Coverage: 27.87% (74604/267697)
Region Coverage: 26.78% (38480/143680)
Branch Coverage: 23.48% (19509/83082)
Coverage Report: http://coverage.selectdb-in.cc/coverage/33abd003562426b97b9bed595d914c492d0048df_33abd003562426b97b9bed595d914c492d0048df/report/index.html

@eldenmoon

Copy link
Copy Markdown
Member Author

picked from #36997

@morningman morningman merged commit d0c0a7b into apache:branch-2.1 Jun 28, 2024
@eldenmoon eldenmoon deleted the pick-rg branch June 28, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants