Skip to content

[fix](scan) catch exceptions thrown in scanner (#36101)#37408

Merged
mrhhsg merged 1 commit into
apache:branch-2.1from
mrhhsg:pick_36101
Jul 12, 2024
Merged

[fix](scan) catch exceptions thrown in scanner (#36101)#37408
mrhhsg merged 1 commit into
apache:branch-2.1from
mrhhsg:pick_36101

Conversation

@mrhhsg

@mrhhsg mrhhsg commented Jul 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Proposed changes

pick #36101

The uncaught exceptions thrown in the scanner will cause the BE to crash.

Proposed changes

Issue Number: close #xxx

@mrhhsg

mrhhsg commented Jul 8, 2024

Copy link
Copy Markdown
Member Author

run buildall

@github-actions

github-actions Bot commented Jul 8, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Jul 8, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.32% (9151/25194)
Line Coverage: 27.87% (74721/268153)
Region Coverage: 26.75% (38528/144055)
Branch Coverage: 23.45% (19524/83256)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7bd993057f72b720ad598f3528ef2f71f66a090d_7bd993057f72b720ad598f3528ef2f71f66a090d/report/index.html

@mrhhsg

mrhhsg commented Jul 9, 2024

Copy link
Copy Markdown
Member Author

run buildall

@doris-robot

doris-robot commented Jul 9, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.34% (9155/25196)
Line Coverage: 27.87% (74770/268244)
Region Coverage: 26.77% (38573/144088)
Branch Coverage: 23.46% (19539/83292)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7bd993057f72b720ad598f3528ef2f71f66a090d_7bd993057f72b720ad598f3528ef2f71f66a090d/report/index.html

@mrhhsg
[fix](scan) catch exceptions thrown in scanner (apache#36101)
45a12ab 
## Proposed changes

The uncaught exceptions thrown in the scanner will cause the BE to
crash.

<!--Describe your changes.-->
@mrhhsg

mrhhsg commented Jul 11, 2024

Copy link
Copy Markdown
Member Author

run buildall

@github-actions

github-actions Bot commented Jul 11, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Jul 11, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.36% (9161/25198)
Line Coverage: 27.90% (74869/268330)
Region Coverage: 26.80% (38630/144135)
Branch Coverage: 23.50% (19580/83330)
Coverage Report: http://coverage.selectdb-in.cc/coverage/45a12ab2f9bc7ae4472151ecfcca3e50a546ebff_45a12ab2f9bc7ae4472151ecfcca3e50a546ebff/report/index.html

@mrhhsg mrhhsg merged commit 87912de into apache:branch-2.1 Jul 12, 2024
@mrhhsg mrhhsg deleted the pick_36101 branch July 12, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrhhsg @doris-robot