Skip to content

[Enhancement] (nereids)implement RefreshLdapCommand in nereids#50655

Merged
starocean999 merged 1 commit into
apache:masterfrom
codeDing18:refreshLdap-nereids
Jun 10, 2025
Merged

[Enhancement] (nereids)implement RefreshLdapCommand in nereids#50655
starocean999 merged 1 commit into
apache:masterfrom
codeDing18:refreshLdap-nereids

Conversation

@codeDing18

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #42581

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented May 7, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@codeDing18 codeDing18 force-pushed the refreshLdap-nereids branch from 9eb93d5 to a2bdc5e Compare June 6, 2025 03:17
@codeDing18

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

Copy link
Copy Markdown
TPC-H: Total hot run time: 33770 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a2bdc5ef96309e010795653453f89cc09c53a789, data reload: false

------ Round 1 ----------------------------------
q1	26304	5048	5053	5048
q2	1942	278	175	175
q3	10309	1228	698	698
q4	10226	1021	530	530
q5	7529	2369	2330	2330
q6	182	164	135	135
q7	880	737	612	612
q8	9322	1281	1065	1065
q9	6842	5085	5087	5085
q10	6848	2335	1884	1884
q11	477	277	274	274
q12	335	345	210	210
q13	17772	3630	3088	3088
q14	223	221	208	208
q15	568	473	478	473
q16	426	432	376	376
q17	605	849	354	354
q18	7545	7166	7155	7155
q19	1593	963	545	545
q20	314	333	223	223
q21	3704	2521	2339	2339
q22	1040	1020	963	963
Total cold run time: 114986 ms
Total hot run time: 33770 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5173	5155	5131	5131
q2	231	312	227	227
q3	2184	2655	2262	2262
q4	1321	1752	1338	1338
q5	4338	4367	4426	4367
q6	234	175	126	126
q7	2023	1897	1784	1784
q8	2617	2516	2520	2516
q9	7241	7172	7000	7000
q10	3042	3217	2811	2811
q11	596	504	535	504
q12	683	760	630	630
q13	3463	3882	3248	3248
q14	304	289	290	289
q15	527	477	473	473
q16	443	502	449	449
q17	1133	1575	1341	1341
q18	7734	7545	7507	7507
q19	814	849	923	849
q20	2104	2129	1849	1849
q21	4806	4566	4369	4369
q22	1100	1083	1027	1027
Total cold run time: 52111 ms
Total hot run time: 50097 ms

@doris-robot

Copy link
Copy Markdown
TPC-DS: Total hot run time: 192534 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a2bdc5ef96309e010795653453f89cc09c53a789, data reload: false

query1	1386	1074	1071	1071
query2	6322	1835	1815	1815
query3	11049	4401	4565	4401
query4	55222	24925	22974	22974
query5	5209	500	460	460
query6	373	229	206	206
query7	5008	539	288	288
query8	295	240	222	222
query9	6302	2634	2648	2634
query10	435	330	274	274
query11	15023	15086	14930	14930
query12	155	109	106	106
query13	1104	540	404	404
query14	10039	6333	6359	6333
query15	198	196	174	174
query16	6998	662	475	475
query17	1049	721	562	562
query18	1573	410	306	306
query19	209	181	180	180
query20	135	124	115	115
query21	206	122	120	120
query22	4494	4716	4467	4467
query23	34232	33584	33663	33584
query24	6606	2435	2413	2413
query25	462	482	410	410
query26	658	276	153	153
query27	2132	521	352	352
query28	3081	2156	2163	2156
query29	622	554	438	438
query30	274	216	187	187
query31	892	876	780	780
query32	79	64	65	64
query33	440	364	309	309
query34	765	851	543	543
query35	814	855	722	722
query36	958	973	883	883
query37	115	108	88	88
query38	4251	4245	4261	4245
query39	1530	1474	1473	1473
query40	217	126	115	115
query41	66	57	61	57
query42	126	121	110	110
query43	500	523	486	486
query44	1370	850	851	850
query45	179	181	177	177
query46	847	1033	645	645
query47	1877	1876	1826	1826
query48	420	439	315	315
query49	639	472	443	443
query50	682	703	415	415
query51	4336	4289	4286	4286
query52	114	115	97	97
query53	232	265	188	188
query54	589	584	511	511
query55	89	89	84	84
query56	317	315	283	283
query57	1187	1174	1122	1122
query58	271	278	265	265
query59	2711	2797	2672	2672
query60	331	338	321	321
query61	130	122	136	122
query62	746	747	682	682
query63	226	190	192	190
query64	1485	1142	716	716
query65	4256	4137	4166	4137
query66	708	405	305	305
query67	16063	15855	15416	15416
query68	6151	902	531	531
query69	541	322	269	269
query70	1213	1137	1085	1085
query71	486	326	297	297
query72	5758	4733	4946	4733
query73	1178	648	356	356
query74	9230	9173	8905	8905
query75	3415	3220	2700	2700
query76	3855	1260	760	760
query77	551	362	291	291
query78	10343	10255	9345	9345
query79	2156	816	576	576
query80	836	509	445	445
query81	513	249	221	221
query82	427	127	94	94
query83	262	264	225	225
query84	296	109	88	88
query85	748	347	310	310
query86	415	315	280	280
query87	4376	4548	4316	4316
query88	3099	2276	2276	2276
query89	404	309	281	281
query90	1768	209	206	206
query91	140	146	117	117
query92	72	58	57	57
query93	2787	947	578	578
query94	698	424	300	300
query95	374	296	330	296
query96	503	574	289	289
query97	2686	2782	2696	2696
query98	235	210	204	204
query99	1326	1398	1254	1254
Total cold run time: 298251 ms
Total hot run time: 192534 ms

@doris-robot

Copy link
Copy Markdown
ClickBench: Total hot run time: 29.05 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a2bdc5ef96309e010795653453f89cc09c53a789, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.11	0.11
query3	0.26	0.19	0.20
query4	1.59	0.20	0.21
query5	0.46	0.44	0.44
query6	1.17	0.68	0.65
query7	0.02	0.01	0.01
query8	0.04	0.04	0.04
query9	0.59	0.50	0.52
query10	0.57	0.57	0.56
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.61	0.60	0.59
query14	0.79	0.79	0.81
query15	0.87	0.86	0.86
query16	0.39	0.38	0.38
query17	1.02	1.05	1.06
query18	0.22	0.21	0.21
query19	1.87	1.82	1.78
query20	0.01	0.02	0.01
query21	15.40	0.89	0.56
query22	0.75	1.25	0.69
query23	14.81	1.40	0.65
query24	6.71	2.17	0.65
query25	0.49	0.26	0.09
query26	0.71	0.17	0.14
query27	0.06	0.05	0.05
query28	10.14	0.89	0.44
query29	12.52	3.98	3.31
query30	0.26	0.09	0.07
query31	2.81	0.61	0.40
query32	3.22	0.56	0.48
query33	2.99	3.13	3.06
query34	15.63	5.11	4.50
query35	4.50	4.52	4.53
query36	0.65	0.50	0.49
query37	0.09	0.06	0.06
query38	0.06	0.04	0.04
query39	0.02	0.02	0.02
query40	0.16	0.14	0.13
query41	0.07	0.03	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.06 s
Total hot run time: 29.05 s

@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 4.76% (1/21) 🎉
Increment coverage report
Complete coverage report

@codeDing18 codeDing18 force-pushed the refreshLdap-nereids branch from a2bdc5e to ccccecc Compare June 6, 2025 05:39
@codeDing18

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

Copy link
Copy Markdown
TPC-H: Total hot run time: 34673 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ccccecc02369fb6b32a140736bfbdbbb5f47eefd, data reload: false

------ Round 1 ----------------------------------
q1	26007	5087	5013	5013
q2	1937	295	185	185
q3	10339	1295	699	699
q4	10280	1006	542	542
q5	8915	2510	2368	2368
q6	284	167	137	137
q7	928	745	620	620
q8	9335	1351	1122	1122
q9	6850	5102	5121	5102
q10	6887	2320	1899	1899
q11	492	298	278	278
q12	344	351	216	216
q13	17786	3673	3155	3155
q14	237	241	218	218
q15	555	503	504	503
q16	432	427	370	370
q17	605	866	355	355
q18	7679	7149	7165	7149
q19	1568	971	577	577
q20	332	333	219	219
q21	3734	3192	2970	2970
q22	1031	1018	976	976
Total cold run time: 116557 ms
Total hot run time: 34673 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5166	5113	5143	5113
q2	237	312	223	223
q3	2185	2702	2319	2319
q4	1350	1854	1464	1464
q5	4525	4418	4435	4418
q6	223	169	125	125
q7	1991	1947	1749	1749
q8	2629	2619	2558	2558
q9	7253	7157	7054	7054
q10	2983	3248	2739	2739
q11	581	510	498	498
q12	663	756	615	615
q13	3506	3931	3322	3322
q14	277	318	279	279
q15	542	505	490	490
q16	439	497	455	455
q17	1150	1583	1377	1377
q18	7809	7503	7290	7290
q19	840	865	859	859
q20	2020	2032	1866	1866
q21	4720	4378	4236	4236
q22	1079	1003	970	970
Total cold run time: 52168 ms
Total hot run time: 50019 ms

@doris-robot

Copy link
Copy Markdown
TPC-DS: Total hot run time: 186238 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ccccecc02369fb6b32a140736bfbdbbb5f47eefd, data reload: false

query1	1008	477	505	477
query2	6557	1834	1829	1829
query3	6755	227	223	223
query4	26552	23813	23227	23227
query5	4346	651	479	479
query6	311	219	198	198
query7	4629	499	293	293
query8	276	239	213	213
query9	8618	2664	2643	2643
query10	476	353	293	293
query11	15539	15151	14848	14848
query12	159	115	114	114
query13	1664	547	407	407
query14	8766	6299	6292	6292
query15	203	195	163	163
query16	7313	650	461	461
query17	1214	720	554	554
query18	1957	396	286	286
query19	194	188	157	157
query20	120	114	123	114
query21	220	125	112	112
query22	4099	4275	3912	3912
query23	34119	33138	33268	33138
query24	8455	2403	2376	2376
query25	557	471	409	409
query26	1232	271	156	156
query27	2753	506	337	337
query28	4341	2141	2126	2126
query29	768	558	450	450
query30	284	216	190	190
query31	913	833	780	780
query32	76	63	65	63
query33	570	390	330	330
query34	788	840	533	533
query35	796	817	738	738
query36	965	978	883	883
query37	106	98	76	76
query38	4142	4256	4124	4124
query39	1491	1404	1415	1404
query40	209	123	105	105
query41	63	64	73	64
query42	142	120	110	110
query43	568	515	476	476
query44	1343	836	833	833
query45	185	173	169	169
query46	880	1026	635	635
query47	1749	1769	1715	1715
query48	402	435	308	308
query49	748	514	392	392
query50	652	672	412	412
query51	4103	4151	4113	4113
query52	113	118	103	103
query53	234	258	193	193
query54	584	573	499	499
query55	82	88	82	82
query56	330	310	290	290
query57	1134	1135	1097	1097
query58	268	264	267	264
query59	2652	2618	2584	2584
query60	337	325	326	325
query61	130	126	125	125
query62	798	734	656	656
query63	225	189	193	189
query64	4347	1033	694	694
query65	4235	4178	4184	4178
query66	1147	431	331	331
query67	15732	15407	15292	15292
query68	6978	897	551	551
query69	497	311	280	280
query70	1215	1166	1109	1109
query71	436	331	315	315
query72	5394	4742	4802	4742
query73	669	608	359	359
query74	9142	9050	8955	8955
query75	3199	3216	2716	2716
query76	3152	1204	761	761
query77	495	390	297	297
query78	10147	10200	9323	9323
query79	2672	830	592	592
query80	678	528	453	453
query81	518	261	227	227
query82	405	125	105	105
query83	270	247	239	239
query84	253	109	89	89
query85	773	404	315	315
query86	390	302	304	302
query87	4425	4540	4296	4296
query88	3801	2318	2284	2284
query89	382	328	292	292
query90	1979	222	212	212
query91	142	145	117	117
query92	82	65	60	60
query93	2591	942	587	587
query94	684	412	313	313
query95	390	290	286	286
query96	495	562	282	282
query97	2707	2767	2659	2659
query98	240	223	202	202
query99	1344	1405	1276	1276
Total cold run time: 273269 ms
Total hot run time: 186238 ms

@doris-robot

Copy link
Copy Markdown
ClickBench: Total hot run time: 29.12 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ccccecc02369fb6b32a140736bfbdbbb5f47eefd, data reload: false

query1	0.04	0.03	0.03
query2	0.12	0.10	0.11
query3	0.23	0.19	0.19
query4	1.58	0.20	0.20
query5	0.46	0.44	0.45
query6	1.13	0.67	0.66
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.60	0.52	0.51
query10	0.56	0.58	0.58
query11	0.16	0.11	0.11
query12	0.15	0.11	0.11
query13	0.61	0.60	0.60
query14	0.79	0.80	0.82
query15	0.87	0.87	0.85
query16	0.38	0.38	0.38
query17	1.06	1.05	1.03
query18	0.23	0.20	0.21
query19	1.96	1.79	1.83
query20	0.01	0.01	0.01
query21	15.40	0.92	0.54
query22	0.76	1.27	0.71
query23	14.83	1.43	0.63
query24	7.25	0.80	1.01
query25	0.43	0.24	0.11
query26	0.60	0.16	0.13
query27	0.05	0.05	0.05
query28	8.97	0.92	0.42
query29	12.56	3.96	3.31
query30	0.25	0.09	0.07
query31	2.82	0.60	0.39
query32	3.24	0.55	0.47
query33	3.10	3.10	3.08
query34	15.79	5.10	4.45
query35	4.51	4.50	4.51
query36	0.67	0.51	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.13	0.14
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 102.7 s
Total hot run time: 29.12 s

@codeDing18

Copy link
Copy Markdown
Contributor Author

run feut

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jun 9, 2025
@github-actions

github-actions Bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actions Bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit 33d159c into apache:master Jun 10, 2025
25 of 26 checks passed
@codeDing18 codeDing18 deleted the refreshLdap-nereids branch June 23, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] (nereids)implement RefreshLdapCommand in nereids

6 participants