Skip to content

branch-3.0: [fix](pipelineX) fix DCHECK error when reuse _join_block in nested loop join #46493#51128

Merged
dataroaring merged 1 commit into
branch-3.0from
auto-pick-46493-branch-3.0
Jun 11, 2025
Merged

branch-3.0: [fix](pipelineX) fix DCHECK error when reuse _join_block in nested loop join #46493#51128
dataroaring merged 1 commit into
branch-3.0from
auto-pick-46493-branch-3.0

Conversation

@github-actions

@github-actions github-actions Bot commented May 21, 2025

Copy link
Copy Markdown
Contributor

Cherry-picked from #46493

@liutang123
[fix](pipelineX) fix DCHECK error when reuse _join_block in nested lo…
df5fbda 
…op join (#46493)

Related Issue: #46498

Co-authored-by: liutang123 <liulijia@gmail.com>
@github-actions github-actions Bot requested a review from dataroaring as a code owner May 21, 2025 11:53
@hello-stephen

hello-stephen commented May 21, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this May 21, 2025
@hello-stephen

hello-stephen commented May 21, 2025

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

hello-stephen commented May 21, 2025

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.11% (10860/26414)
Line Coverage 31.91% (92715/290531)
Region Coverage 30.98% (47821/154375)
Branch Coverage 27.44% (24481/89214)

dataroaring
dataroaring approved these changes May 26, 2025
View reviewed changes

@dataroaring dataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label May 26, 2025
@github-actions

github-actions Bot commented May 26, 2025

Copy link
Copy Markdown
Contributor Author

PR approved by at least one committer and no changes requested.

@github-actions

github-actions Bot commented May 26, 2025

Copy link
Copy Markdown
Contributor Author

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 67b539c into branch-3.0 Jun 11, 2025
20 of 24 checks passed
@github-actions github-actions Bot deleted the auto-pick-46493-branch-3.0 branch June 11, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hello-stephen @dataroaring @liutang123