Skip to content

[fix](nereids) intersect/except runtime filter project wrong child slot#52435

Merged
englefly merged 2 commits into
apache:masterfrom
englefly:setop-child-slot
Jun 30, 2025
Merged

[fix](nereids) intersect/except runtime filter project wrong child slot#52435
englefly merged 2 commits into
apache:masterfrom
englefly:setop-child-slot

Conversation

@englefly

@englefly englefly commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

tpcds 38/87
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@englefly

englefly commented Jun 27, 2025

Copy link
Copy Markdown
Contributor Author

run buildall

@Thearas

Thearas commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jun 27, 2025
@github-actions

github-actions Bot commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actions Bot commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen

hello-stephen commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@englefly

englefly commented Jun 30, 2025

Copy link
Copy Markdown
Contributor Author

run performance

@doris-robot

doris-robot commented Jun 30, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 33791 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d530eac20620066710dbf185ecf0d491770a02a0, data reload: false

------ Round 1 ----------------------------------
q1	17585	5242	5083	5083
q2	1926	271	183	183
q3	10322	1264	697	697
q4	10210	991	502	502
q5	7496	2328	2327	2327
q6	176	162	126	126
q7	886	728	622	622
q8	9326	1287	1092	1092
q9	6755	5058	5021	5021
q10	6857	2369	1967	1967
q11	462	279	289	279
q12	340	341	205	205
q13	17764	3678	3105	3105
q14	222	234	204	204
q15	542	484	485	484
q16	418	428	367	367
q17	591	833	367	367
q18	7517	7219	7185	7185
q19	1339	944	535	535
q20	340	329	216	216
q21	3766	2569	2278	2278
q22	1015	987	946	946
Total cold run time: 105855 ms
Total hot run time: 33791 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5444	5077	5057	5057
q2	239	319	217	217
q3	2130	2612	2247	2247
q4	1349	1741	1304	1304
q5	4192	4223	4341	4223
q6	205	167	122	122
q7	1992	1956	1776	1776
q8	2571	2543	2462	2462
q9	7162	7053	7108	7053
q10	3139	3306	2797	2797
q11	567	501	480	480
q12	700	765	613	613
q13	3536	3820	3295	3295
q14	275	289	291	289
q15	505	480	465	465
q16	436	502	462	462
q17	1123	1469	1406	1406
q18	7254	7159	7044	7044
q19	756	748	767	748
q20	1886	1973	1845	1845
q21	4619	4380	4294	4294
q22	1048	1024	982	982
Total cold run time: 51128 ms
Total hot run time: 49181 ms

@doris-robot

doris-robot commented Jun 30, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 184820 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d530eac20620066710dbf185ecf0d491770a02a0, data reload: false

query1	999	395	384	384
query2	6541	1797	1813	1797
query3	6737	213	210	210
query4	26325	23424	23386	23386
query5	4356	587	425	425
query6	301	234	203	203
query7	4628	479	290	290
query8	261	215	210	210
query9	8637	2586	2577	2577
query10	468	353	271	271
query11	15808	14964	14802	14802
query12	160	105	102	102
query13	1649	534	403	403
query14	9408	5672	5648	5648
query15	219	192	181	181
query16	7625	617	449	449
query17	1185	698	583	583
query18	2031	403	308	308
query19	193	191	166	166
query20	117	118	109	109
query21	211	124	103	103
query22	4048	4112	4043	4043
query23	33811	33130	33045	33045
query24	8559	2344	2434	2344
query25	542	458	384	384
query26	1233	272	143	143
query27	2744	509	338	338
query28	4303	2140	2095	2095
query29	734	566	436	436
query30	290	214	188	188
query31	928	835	735	735
query32	75	67	63	63
query33	545	368	302	302
query34	788	827	531	531
query35	774	798	712	712
query36	951	966	859	859
query37	114	96	74	74
query38	4092	4151	4018	4018
query39	1502	1444	1410	1410
query40	226	122	108	108
query41	60	54	49	49
query42	122	105	106	105
query43	490	516	511	511
query44	1273	798	796	796
query45	173	170	159	159
query46	823	1001	625	625
query47	1725	1834	1724	1724
query48	382	415	300	300
query49	748	481	381	381
query50	634	678	405	405
query51	4087	4080	4166	4080
query52	102	102	93	93
query53	226	253	183	183
query54	578	573	490	490
query55	83	80	81	80
query56	289	288	286	286
query57	1198	1181	1130	1130
query58	283	241	266	241
query59	2700	2883	2750	2750
query60	333	301	318	301
query61	121	120	126	120
query62	773	729	655	655
query63	223	185	187	185
query64	4275	1025	657	657
query65	4220	4187	4150	4150
query66	1081	404	356	356
query67	15502	15442	15402	15402
query68	8931	887	517	517
query69	467	303	269	269
query70	1190	1094	1043	1043
query71	450	313	300	300
query72	5485	4772	4860	4772
query73	738	692	353	353
query74	8880	8850	8722	8722
query75	4155	3169	2727	2727
query76	3611	1142	722	722
query77	781	379	286	286
query78	10027	10218	9259	9259
query79	2054	899	592	592
query80	769	492	443	443
query81	472	257	227	227
query82	423	127	94	94
query83	281	243	236	236
query84	296	110	114	110
query85	773	363	318	318
query86	336	286	308	286
query87	4527	4519	4362	4362
query88	3281	2269	2245	2245
query89	392	313	277	277
query90	1937	201	208	201
query91	138	136	109	109
query92	72	57	60	57
query93	1229	960	597	597
query94	682	414	317	317
query95	423	291	287	287
query96	490	559	277	277
query97	2723	2732	2634	2634
query98	232	203	203	203
query99	1489	1382	1329	1329
Total cold run time: 274356 ms
Total hot run time: 184820 ms

@doris-robot

doris-robot commented Jun 30, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 29.73 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d530eac20620066710dbf185ecf0d491770a02a0, data reload: false

query1	0.05	0.03	0.03
query2	0.07	0.05	0.04
query3	0.24	0.08	0.08
query4	1.62	0.11	0.11
query5	0.43	0.44	0.42
query6	1.20	0.67	0.67
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.59	0.50	0.52
query10	0.57	0.57	0.58
query11	0.16	0.11	0.11
query12	0.15	0.12	0.11
query13	0.63	0.62	0.62
query14	0.79	0.83	0.81
query15	0.90	0.85	0.88
query16	0.40	0.40	0.39
query17	1.12	1.04	1.10
query18	0.23	0.22	0.21
query19	1.95	1.88	1.85
query20	0.01	0.01	0.01
query21	15.38	0.87	0.54
query22	0.76	1.04	0.71
query23	15.01	1.37	0.60
query24	7.75	0.97	0.93
query25	0.53	0.23	0.09
query26	0.62	0.17	0.15
query27	0.06	0.06	0.05
query28	9.24	0.93	0.45
query29	12.52	3.94	3.35
query30	0.25	0.09	0.07
query31	2.84	0.58	0.40
query32	3.22	0.55	0.49
query33	3.05	3.07	3.16
query34	16.07	5.43	4.77
query35	4.79	4.77	4.77
query36	0.69	0.51	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.18	0.14	0.15
query41	0.08	0.02	0.02
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.46 s
Total hot run time: 29.73 s

@englefly englefly merged commit ccc336c into apache:master Jun 30, 2025
26 of 28 checks passed
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
@englefly
[fix](nereids) intersect/except runtime filter project wrong child sl…
18dd6f9 
…ot (apache#52435)

### What problem does this PR solve?
a bug introduced by apache#49947 
tpcds 38/87 are involved
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
@englefly
[fix](nereids) intersect/except runtime filter project wrong child sl…
119ff85 
…ot (apache#52435)

### What problem does this PR solve?
a bug introduced by apache#49947 
tpcds 38/87 are involved
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
@englefly
[fix](nereids) intersect/except runtime filter project wrong child sl…
784a6f3 
…ot (apache#52435)

### What problem does this PR solve?
a bug introduced by apache#49947 
tpcds 38/87 are involved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes
@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@englefly @Thearas @hello-stephen @doris-robot @starocean999 @morrySnow