Skip to content

[Fix](restapi) fix node action restapi throw '-parameters' error because of PathVariable annotation without value declaration#59708

Merged
yx-keith merged 1 commit into
apache:masterfrom
heguanhui:bugfix/fix-node-action-error-issues
Jan 23, 2026
Merged

[Fix](restapi) fix node action restapi throw '-parameters' error because of PathVariable annotation without value declaration#59708
yx-keith merged 1 commit into
apache:masterfrom
heguanhui:bugfix/fix-node-action-error-issues

Conversation

@heguanhui

@heguanhui heguanhui commented Jan 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Problem Summary:
fix node action restapi throw '-parameters' error because of PathVariable annotation without value declaration

Release note

None

Check List (For Author)

  • Test

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

[Fix](restapi) fix node action restapi throw '-parameters' error beca…
47f9a5a 
…use of PathVariable annotation without value declaration
@heguanhui heguanhui force-pushed the bugfix/fix-node-action-error-issues branch from 76586ed to 47f9a5a Compare January 9, 2026 04:00
@morningman morningman self-assigned this Jan 11, 2026
@morningman

morningman commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

run buildall

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jan 12, 2026
@github-actions

github-actions Bot commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actions Bot commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen

hello-stephen commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

@doris-robot

doris-robot commented Jan 12, 2026

Copy link
Copy Markdown
TPC-H: Total hot run time: 31241 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 47f9a5a3903929dced096725f54a2362be883968, data reload: false

------ Round 1 ----------------------------------
q1	17602	4231	4087	4087
q2	2053	352	252	252
q3	10125	1280	706	706
q4	10207	782	321	321
q5	7521	2061	1826	1826
q6	184	174	139	139
q7	924	789	646	646
q8	9265	1409	1161	1161
q9	4832	4495	4561	4495
q10	6773	1781	1393	1393
q11	513	300	267	267
q12	668	727	568	568
q13	17785	3793	3049	3049
q14	285	300	273	273
q15	584	508	502	502
q16	699	674	639	639
q17	673	771	558	558
q18	6745	6349	6400	6349
q19	1090	950	587	587
q20	413	351	243	243
q21	2999	2423	2211	2211
q22	1044	1015	969	969
Total cold run time: 102984 ms
Total hot run time: 31241 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4095	4060	4050	4050
q2	339	390	305	305
q3	2075	2580	2204	2204
q4	1331	1728	1300	1300
q5	4119	3977	3990	3977
q6	213	172	130	130
q7	1860	1818	1672	1672
q8	2800	2532	2405	2405
q9	7319	7103	7039	7039
q10	2517	2711	2293	2293
q11	547	472	462	462
q12	732	726	605	605
q13	3514	4094	3284	3284
q14	280	294	295	294
q15	536	510	514	510
q16	748	697	649	649
q17	1208	1342	1362	1342
q18	8150	8125	7551	7551
q19	893	862	886	862
q20	2002	2046	1962	1962
q21	4754	4578	4277	4277
q22	1127	1090	1047	1047
Total cold run time: 51159 ms
Total hot run time: 48220 ms

@doris-robot

doris-robot commented Jan 12, 2026

Copy link
Copy Markdown
TPC-DS: Total hot run time: 172948 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 47f9a5a3903929dced096725f54a2362be883968, data reload: false

query5	4429	601	425	425
query6	321	222	208	208
query7	4224	449	258	258
query8	328	245	267	245
query9	8740	2628	2648	2628
query10	520	365	334	334
query11	15171	15104	14903	14903
query12	168	122	111	111
query13	1237	452	375	375
query14	5520	2973	2684	2684
query14_1	2639	2595	2577	2577
query15	202	197	182	182
query16	972	465	443	443
query17	986	670	563	563
query18	2433	445	343	343
query19	233	225	196	196
query20	121	120	117	117
query21	214	146	129	129
query22	3954	4134	4048	4048
query23	16036	15581	15433	15433
query23_1	15438	15468	15430	15430
query24	7425	1555	1162	1162
query24_1	1194	1187	1161	1161
query25	572	481	421	421
query26	1244	269	158	158
query27	2754	447	289	289
query28	4608	2145	2135	2135
query29	848	550	462	462
query30	311	245	213	213
query31	777	629	545	545
query32	76	65	79	65
query33	548	350	291	291
query34	913	869	524	524
query35	718	765	686	686
query36	856	885	824	824
query37	133	97	83	83
query38	2674	2708	2701	2701
query39	778	768	763	763
query39_1	705	736	702	702
query40	221	134	116	116
query41	72	70	67	67
query42	106	103	99	99
query43	456	454	453	453
query44	1319	729	731	729
query45	191	183	188	183
query46	841	948	591	591
query47	1473	1496	1405	1405
query48	333	322	245	245
query49	619	431	343	343
query50	637	269	206	206
query51	3828	3818	3827	3818
query52	108	108	94	94
query53	302	325	277	277
query54	306	271	259	259
query55	81	78	72	72
query56	303	293	318	293
query57	1026	1086	960	960
query58	268	253	251	251
query59	1959	2159	2084	2084
query60	315	318	298	298
query61	167	150	154	150
query62	390	352	318	318
query63	297	267	269	267
query64	5042	1262	965	965
query65	3847	3762	3785	3762
query66	1444	412	302	302
query67	15370	15583	14506	14506
query68	6981	973	712	712
query69	501	345	306	306
query70	1035	850	956	850
query71	366	295	268	268
query72	6156	3341	3422	3341
query73	773	715	317	317
query74	8798	8773	8546	8546
query75	2837	2809	2424	2424
query76	3368	1058	649	649
query77	530	370	275	275
query78	9659	9684	9106	9106
query79	1258	907	571	571
query80	597	566	469	469
query81	509	255	228	228
query82	205	145	115	115
query83	271	262	235	235
query84	287	112	96	96
query85	893	514	448	448
query86	382	296	276	276
query87	2856	2811	2768	2768
query88	3121	2250	2229	2229
query89	395	360	320	320
query90	2234	160	156	156
query91	171	169	140	140
query92	88	65	59	59
query93	1134	899	524	524
query94	568	292	290	290
query95	570	319	348	319
query96	578	450	201	201
query97	2300	2377	2346	2346
query98	209	199	196	196
query99	582	611	561	561
Total cold run time: 252191 ms
Total hot run time: 172948 ms

@hello-stephen

hello-stephen commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

@yx-keith yx-keith merged commit 9ff379b into apache:master Jan 23, 2026
29 of 30 checks passed
@heguanhui heguanhui deleted the bugfix/fix-node-action-error-issues branch January 23, 2026 16:08
This was referenced Jul 1, 2026
Open
Merged
yiguolei pushed a commit that referenced this pull request Jul 1, 2026
@CalvinKirs @heguanhui
branch-4.1: [fix](auth) add auth check for manager node and query qer…
bdb906e 
…ror REST APIs (#65080)

cherry-pick #65042
cherry-pick #59708

---------

Co-authored-by: heguanhui <hgh_wy163mail@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes
@yx-keith yx-keith yx-keith approved these changes

Assignees

@morningman morningman

Labels

approved Indicates a PR has been approved by one committer. dev/4.1.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@heguanhui @Thearas @morningman @hello-stephen @doris-robot @yx-keith @yiguolei