Review analysis of PR #60170: ST_Distance, ST_GeometryType, ST_Length geo functions#60716
Closed
Review analysis of PR #60170: ST_Distance, ST_GeometryType, ST_Length geo functions#60716
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Copilot
AI
changed the title
[WIP] Review PR 60170 for code style and agreement compliance
Review analysis of PR #60170: ST_Distance, ST_GeometryType, ST_Length geo functions
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed code review of PR #60170 which adds three spatial functions:
ST_Distance,ST_GeometryType,ST_Length.Review Findings
✅ Code Style Compliance
StDistance.java,StGeometryType.java,StLength.java) match existing patterns fromStContains.java,StDistanceSphere.javageo_types.cppconventions with virtual methods onGeoShapebase class✅ Algorithm Correctness
Intersects()before computing distance (returns 0 for intersecting geometries)S2Earth::GetDistanceMeters()for spherical distance✅ Review Comments Resolved
privateaccess for helper methodsTest Coverage
geo_types_test.cppcovering all geometry combinationsConclusion
Recommend merge. No blocking issues found. Code quality is good, all reviewer feedback addressed.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.