Add MiddleManager drain rollout strategy#18
Open
aruraghuwanshi wants to merge 1 commit into
Open
Conversation
Introduce an opt-in CRD strategy that drains MiddleManager StatefulSet pods before rolling them, with status visibility, timeout handling, and upstream Druid API auth plumbing.
Member
|
Instead of using RollingUpdate with partition manipulation, why not just switch to MiddleManager StatefulSet to OnDelete update strategy. With OnDelete, Kubernetes never auto-replaces pods, the operator explicitly deletes each pod when ready. What are your thoughts ? Just thinking from a perspective on lowering the hops in state machine. ( also reduce API calls to k8s API ). |
Member
|
Also thinking on simpler terms, shouldn't the MM process support graceful termination ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an opt-in MiddleManager drain rollout strategy for Druid clusters.
When
spec.middleManagerDrainStrategyis set, the operator drains each MiddleManager StatefulSet pod before allowing Kubernetes to replace it during a rolling update. This reduces the chance of interrupting active Kafka/Kinesis ingestion tasks during MiddleManager upgrades.What Changed
spec.middleManagerDrainStrategyas a pointer-presence CRD option:status.middleManagerDrainto expose rollout progress and support recovery after operator restarts.drainTimeout, default1hpodReadyTimeout, default30mspec.authDruid API credential plumbing.docs/features.mdanddocs/druid_cr.md.Example