fix: correct default healthcheck probe logic and enable probes by default#20
Open
AdheipSingh wants to merge 1 commit into
Open
fix: correct default healthcheck probe logic and enable probes by default#20AdheipSingh wants to merge 1 commit into
AdheipSingh wants to merge 1 commit into
Conversation
ee31246 to
ab7f3fc
Compare
himadrisingh
approved these changes
May 15, 2026
Member
|
Codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #XXXX.
Description
Summary
setDefaultProbethat incorrectly applied readiness paths to startup probes!=conditions with explicit equality checks using probe type constantsDefaultProbesfromboolto*bool— nil (field omitted) defaults to true, explicitfalsepreserved for backward compatibilityTest plan
/status/health, readiness/druid/historical/v1/readiness, startup/druid/historical/v1/readiness/status/health, readiness/druid/broker/v1/readiness, startup/druid/broker/v1/readinessdefaultProbes: falseremoves all default probes (backward compat)defaultProbes: truerestores all default probesThis PR has:
Key changed/added files in this PR
MyFooOurBarTheirBaz