feat: Add counters, remove warehouse from DataServerQueryHandlers#19196
Merged
Conversation
Two changes to MSQ DataServerQueryHandlers: 1) Add "queries" and "totalQueries" counters, reflecting queries made to realtime servers to get realtime data. 2) Remove dependency on QueryToolChestWarehouse and QueryToolChest. When mapping functions from these are needed, the query logic passes it in rather than it being derived from the toolchest. Web console changes are included for (1). Realtime query counters are shown in an ↙ icon next to VSF counters.
github-actions
Bot
added
Area - Batch Ingestion
Area - Web Console
Area - MSQ
gianm
changed the title
clintropolis
approved these changes
Mar 23, 2026
gianm
added a commit
to gianm/druid
that referenced
this pull request
Mar 24, 2026
PR apache#19196 was meant to use a bottom-left icon for realtime queries, not a bottom-right icon.
capistrant
pushed a commit
that referenced
this pull request
Mar 24, 2026
PR #19196 was meant to use a bottom-left icon for realtime queries, not a bottom-right icon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to MSQ DataServerQueryHandlers:
Add "queries" and "totalQueries" counters, reflecting queries made to realtime servers to get realtime data.
Remove dependency on QueryToolChestWarehouse and QueryToolChest. When mapping functions from these are needed, the query logic passes it in rather than it being derived from the toolchest.
Web console changes are included for (1). Realtime query counters are shown in an ↙ icon next to VSF counters.