Skip to content

ci: pre-pull Testcontainers images in worker before unit tests (#19464)#19465

Open
Shekharrajak wants to merge 2 commits into
apache:masterfrom
Shekharrajak:feature/19464-kafka-fault-tolerance-flake-fix
Open

ci: pre-pull Testcontainers images in worker before unit tests (#19464)#19465
Shekharrajak wants to merge 2 commits into
apache:masterfrom
Shekharrajak:feature/19464-kafka-fault-tolerance-flake-fix

Conversation

@Shekharrajak
Copy link
Copy Markdown
Contributor

@Shekharrajak Shekharrajak commented May 15, 2026

Fixes #19464.

Description

Once the image is in the runner's local Docker daemon cache, KafkaContainer start in KafkaResource becomes a pure container-spinup (~5-15 s) instead of pull+spinup (~30-90 s + Docker Hub variance). The 60 s LatchableEmitter wall now has 4-12× more headroom.

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@jtuglu1
Copy link
Copy Markdown
Contributor

jtuglu1 commented May 15, 2026

Can we do this for the other container images as well? e.g. ZK, metadata DB

@github-actions github-actions Bot added the GHA label May 15, 2026
@Shekharrajak
Copy link
Copy Markdown
Contributor Author

Checking,
looks like ZK is JVM based in test and metadata DB is postgres. But I have other list:

apache/kafka:4.2.0
            postgres:16-alpine
            minio/minio:latest
            hashicorp/consul:1.18
            tabulario/iceberg-rest:1.6.0
            localstack/localstack:4.13.1
            mcr.microsoft.com/azure-storage/azurite:3.35.0
            osixia/openldap:1.5.0
            rancher/k3s:v1.35.0-k3s1

Copy link
Copy Markdown
Member

@FrankChen021 FrankChen021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.

Reviewed 1 of 1 changed files.


This is an automated review by Codex GPT-5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: KafkaIndexFaultToleranceTest times out at Testcontainers Kafka startup

3 participants