Skip to content

[INFRA] Set up default rulesets for default and release branches #19466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asf-gitbox-commits wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −0
Open

[INFRA] Set up default rulesets for default and release branches #19466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .asf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,19 @@ github:
edit_comment_discussion: "Re: [D] {title} ({repository})"
delete_comment_discussion: "Re: [D] {title} ({repository})"

rulesets:
- name: "Default Branch Protection"
type: branch
branches:
includes:
- "~DEFAULT_BRANCH"
- "release/*"
Copy link
Copy Markdown
Member

@FrankChen021 FrankChen021 May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Release branch ruleset misses Druid release branches

The ruleset only includes ~DEFAULT_BRANCH, release/*, and rel/*, but Druid's release process names release branches as bare versions such as 0.17.0 and 24.0.0, and the repository already has version-named release refs. As written, the new deletion and force-push protections will not apply to those release branches, which defeats the PR's stated goal of protecting default and release branches. Please add a pattern that matches Druid's version-named release branches, or otherwise align the ruleset with the project's release branch naming.

- "rel/*"
excludes: []
bypass_teams:
- root
restrict_deletion: true
restrict_force_push: true
notifications:
commits: commits@druid.apache.org
issues: commits@druid.apache.org
Expand Down
Loading