Skip to content

Downgrade Netty version 4.1 -> 4.0#5059

Merged
gianm merged 2 commits into
apache:masterfrom
metamx:netty-downgrade
Nov 9, 2017
Merged

Downgrade Netty version 4.1 -> 4.0#5059
gianm merged 2 commits into
apache:masterfrom
metamx:netty-downgrade

Conversation

@leventov

@leventov leventov commented Nov 8, 2017

Copy link
Copy Markdown
Member

Because of #4390 and the problems with client: #4973 (comment), I agree now that it's better to downgrade, as was suggested here: #4390 (comment)

@b-slim

b-slim commented Nov 8, 2017

Copy link
Copy Markdown
Contributor

@leventov should we backport this?

@leventov

leventov commented Nov 8, 2017

Copy link
Copy Markdown
Member Author

If it passes tests...

@leventov leventov added this to the 0.11.0 milestone Nov 8, 2017
@leventov

leventov commented Nov 9, 2017

Copy link
Copy Markdown
Member Author

@b-slim @himanshug @drcrallen could you please review this PR?

@b-slim

b-slim commented Nov 9, 2017

Copy link
Copy Markdown
Contributor

👍 after testing

@b-slim

b-slim commented Nov 9, 2017

Copy link
Copy Markdown
Contributor

@leventov not sure why this PR has a design review tag? seems to me we are reverting to the known working version of Netty.

@gianm

gianm commented Nov 9, 2017

Copy link
Copy Markdown
Contributor

LGTM.

@gianm gianm merged commit 95154f9 into apache:master Nov 9, 2017
@leventov leventov deleted the netty-downgrade branch November 9, 2017 20:37
@himanshug

Copy link
Copy Markdown
Contributor

👍
a little late to review but we deployed this patch and can confirm that it fixes the problem mentioned in #4973 (comment)

gianm pushed a commit to gianm/druid that referenced this pull request Nov 9, 2017
gianm added a commit that referenced this pull request Nov 10, 2017
leventov pushed a commit to metamx/druid that referenced this pull request Nov 13, 2017
@leventov leventov mentioned this pull request Oct 4, 2018
riovic918data pushed a commit to riovic918data/druid that referenced this pull request Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants