[Backport] Use daemon thread pool for AsyncHttpClient in emitters#5069
Merged
Conversation
* use daemon thread pool for AsyncHttpClient in emitters * changed to use existing helper methods * refactored creation of AsyncHttpClient
leventov
approved these changes
Nov 10, 2017
Member
|
@gianm thanks for creating those backports |
Contributor
Author
|
@leventov no problem; I have a script to do it so it's pretty easy :) |
Member
|
@gianm could you please fix compilation |
Contributor
Author
|
@leventov should be fixed now |
Contributor
|
@gianm can you share your script ? |
Contributor
Author
|
@himanshug it's https://gist.github.com/gianm/68145b09a55e6f6460a11ae9adfc25a4 For some reason the "milestone" and "labels" never get set, I'm not sure what's wrong there. If you ever figure it out let me know how to fix it :) |
leventov
pushed a commit
to metamx/druid
that referenced
this pull request
Nov 13, 2017
…ache#5069) * Use daemon thread pool for AsyncHttpClient in emitters (apache#5057) * use daemon thread pool for AsyncHttpClient in emitters * changed to use existing helper methods * refactored creation of AsyncHttpClient * Avoid Execs, it's not available in this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #5057 to 0.11.0.