Optimize overshadowed segments computation#7595
Merged
leventov merged 33 commits intoJun 7, 2019
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses part of #7571
This patch moves the computation of overshadowed segments to
SQLMetadataSegmentManager's poll method. The endpoint inMetadataResourceandDruidCoordinatorRuleRunneruse the APIMetadataSegmentManager#findOvershadowedSegments()to get overshadowed segments without building theVersionedIntervalTimelineevery time.Renamed
SegmentWithOvershadowedStatustoDataSegmentWithOvershadowedStatus.This PR does not address the mutability of
DataSegmentand getting rid of interning inMatadataSegmentView