Skip to content

[FLINK-34908][pipeline-connector][starrocks] Fix MySQL to doris pipeline will lose precision for timestamp type #3417

Closed
ChengJie1053 wants to merge 3 commits into
apache:masterfrom
ChengJie1053:master-StarRocksUtils
Closed

[FLINK-34908][pipeline-connector][starrocks] Fix MySQL to doris pipeline will lose precision for timestamp type #3417
ChengJie1053 wants to merge 3 commits into
apache:masterfrom
ChengJie1053:master-StarRocksUtils

Conversation

@ChengJie1053

Copy link
Copy Markdown
Member

#3207

I found this code while learning the flink cdc source code, I think starrocks may have similar problems, if this piece has been done, I will close the pr

…ipeline will lose precision for timestamp type
@yuxiqian

yuxiqian commented Jun 17, 2024

Copy link
Copy Markdown
Member

Thanks for @ChengJie1053's great work, could you please add some tests to verify this change? Also some existing testcases might need to be tweaked to reflect this change:

Error:  Failures: 
Error:    EventRecordSerializationSchemaTest.testMixedSchemaAndDataChanges:133->verifySerializeResult:275

+expected:<{__op=0, col1=1, col2=true, col3=2023-11-27 18:00:00}>
- but was:<{__op=0, col1=1, col2=true, col3=2023-11-27 18:00:00.000000}>

@ChengJie1053

Copy link
Copy Markdown
Member Author

Thanks for @ChengJie1053's great work, could you please add some tests to verify this change? Also some existing testcases might need to be tweaked to reflect this change:

Error:  Failures: 
Error:    EventRecordSerializationSchemaTest.testMixedSchemaAndDataChanges:133->verifySerializeResult:275

+expected:<{__op=0, col1=1, col2=true, col3=2023-11-27 18:00:00}>
- but was:<{__op=0, col1=1, col2=true, col3=2023-11-27 18:00:00.000000}>

Ok, thanks for reviewing the code for me

@gong

gong commented Jun 18, 2024

Copy link
Copy Markdown
Contributor

@ChengJie1053 https://issues.apache.org/jira/projects/FLINK/issues/FLINK-34908?filter=allissues Hello, I found starrocks only support second level precision, so I did't modify starrocks pipeline. I added comment in issue. You can visit link https://docs.starrocks.io/zh/docs/sql-reference/data-types/date-types/DATETIME/

@ChengJie1053

Copy link
Copy Markdown
Member Author

@ChengJie1053 https://issues.apache.org/jira/projects/FLINK/issues/FLINK-34908?filter=allissues Hello, I found starrocks only support second level precision, so I did't modify starrocks pipeline. I added comment in issue. You can visit link https://docs.starrocks.io/zh/docs/sql-reference/data-types/date-types/DATETIME/

Okay, thank you. Thank you for your guidance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants