[FLINK-34908][pipeline-connector][starrocks] Fix MySQL to doris pipeline will lose precision for timestamp type #3417
Conversation
…ipeline will lose precision for timestamp type
|
Thanks for @ChengJie1053's great work, could you please add some tests to verify this change? Also some existing testcases might need to be tweaked to reflect this change: Error: Failures:
Error: EventRecordSerializationSchemaTest.testMixedSchemaAndDataChanges:133->verifySerializeResult:275
+expected:<{__op=0, col1=1, col2=true, col3=2023-11-27 18:00:00}>
- but was:<{__op=0, col1=1, col2=true, col3=2023-11-27 18:00:00.000000}> |
Ok, thanks for reviewing the code for me |
|
@ChengJie1053 https://issues.apache.org/jira/projects/FLINK/issues/FLINK-34908?filter=allissues Hello, I found starrocks only support second level precision, so I did't modify starrocks pipeline. I added comment in issue. You can visit link https://docs.starrocks.io/zh/docs/sql-reference/data-types/date-types/DATETIME/ |
Okay, thank you. Thank you for your guidance |
#3207
I found this code while learning the flink cdc source code, I think starrocks may have similar problems, if this piece has been done, I will close the pr