Skip to content

[FLINK-35888][cdc-connector][paimon] Add e2e test for PaimonDataSink.#3491

Closed
lvyanquan wants to merge 3 commits into
apache:masterfrom
lvyanquan:FLINK-35888
Closed

[FLINK-35888][cdc-connector][paimon] Add e2e test for PaimonDataSink.#3491
lvyanquan wants to merge 3 commits into
apache:masterfrom
lvyanquan:FLINK-35888

Conversation

@lvyanquan

@lvyanquan lvyanquan commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

Add e2e test for PaimonDataSink.
This can be merged after #3818.

Coauthor with @yuxiqian

@lvyanquan

Copy link
Copy Markdown
Contributor Author

@yuxiqian Can you help to review this?

@yuxiqian yuxiqian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for @lvyanquan's great work, I left some minor comments.

Comment thread flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/pom.xml
Comment thread flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/pom.xml Outdated
@github-actions github-actions Bot removed the runtime label Jul 24, 2024

@yuxiqian yuxiqian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for @lvyanquan's great work!

@yuxiqian

Copy link
Copy Markdown
Member

Seems CI is failing since 17ff659 doesn't generate test jar by default, which is required by Paimon E2e tests. Some changes like

    <build>
        <plugins>
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-jar-plugin</artifactId>
                <executions>
                    <execution>
                        <id>test-jar</id>
                        <goals>
                            <goal>test-jar</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>
        </plugins>
    </build>

might be necessary.

@github-actions

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs.

@github-actions github-actions Bot added the Stale label Sep 28, 2024
@github-actions

Copy link
Copy Markdown

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

@github-actions github-actions Bot closed this Oct 28, 2024
@yuxiqian

Copy link
Copy Markdown
Member

@leonardBang Could you please reopen this?

@leonardBang leonardBang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lvyanquan and @yuxiqian for the co-work, LGTM

@yuxiqian yuxiqian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for @lvyanquan's great work, I left some minor concerns about some changes in PipelineTestEnvironment, not sure if it's relevant to failing CI workflow.

Comment thread flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/pom.xml Outdated
@lvyanquan

Copy link
Copy Markdown
Contributor Author

Close this and trace in #3818 as this pr rely on #3818 to fix some bugs and #3818 also need to verify by e2e.

@lvyanquan lvyanquan closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants