[minor][cdc-runtime] Run schema coordinator logic asynchronously to avoid blocking the main thread#3577
Merged
leonardBang merged 3 commits intoAug 27, 2024
Conversation
…g the main thread
yuxiqian
force-pushed
the
fix/run-coordinator-in-event-loop
branch
from
f0ba62c to
7a7477f
Compare
Contributor
|
@loserwang1024 Would you like to review this PR when you have time ? |
leonardBang
reviewed
Aug 27, 2024
| executorService, | ||
| metadataApplier, | ||
| routes, | ||
| SchemaChangeBehavior.EVOLVE); |
leonardBang
changed the title
leonardBang
approved these changes
Aug 27, 2024
leonardBang
left a comment
leonardBang
left a comment
Contributor
There was a problem hiding this comment.
Thanks @yuxiqian for the fix, +1. The failed case reason is clear and not related to this PR, will merge this PR first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tweaks
SchemaRegistrycoordinator to let it handle requests / trigger checkpoints in background threads to avoid blocking the main thread.