[BP-3.2][docs] Update download links to up-to-date cdc version#3765
Conversation
yuxiqian
changed the title
yuxiqian
force-pushed
the
docs/bump-download-links-bp-3.2
branch
from
611abd7 to
002fe3d
Compare
Signed-off-by: yuxiqian <34335406+yuxiqian@users.noreply.github.com>
yuxiqian
force-pushed
the
docs/bump-download-links-bp-3.2
branch
from
002fe3d to
0a88d4e
Compare
Signed-off-by: yuxiqian <34335406+yuxiqian@users.noreply.github.com>
Signed-off-by: yuxiqian <34335406+yuxiqian@users.noreply.github.com>
Signed-off-by: yuxiqian <34335406+yuxiqian@users.noreply.github.com>
| }, | ||
| { | ||
| "pattern": "^https://repo1.maven.org/maven2/org/apache/flink.*SNAPSHOT.*" | ||
| "pattern": "^https://repo1.maven.org/maven2/org/apache/flink.*" |
There was a problem hiding this comment.
@yuxiqian SNAPSHOT version should not be available，but released version should be available. So can you explain the reason?
There was a problem hiding this comment.
Currently, CDC CI uses markdown-link-check to validate dead links and Hugo project to generate static websites.
Interpolated URL links like https://repo1.maven.org/maven2/org/apache/flink/flink-sql-connector-db2-cdc/{{< param Version >}}/flink-sql-connector-db2-cdc-{{< param Version >}}.jar are replaced to valid link when Hugo compiles it, but markdown-link-check doesn't understand it and will trigger a false alarm.
I also agree that silencing all maven link checks isn't very ideal. Any suggestions on this?
There was a problem hiding this comment.
Thanks for the quick response. Mind you also take a look at #3766 that fixes this in the master branch?
2 participants
Use parameterized version string instead of write hard-encoded links.