Skip to content

[FLINK-34455] Move RestoreMode from flink-runtime to flink-core#24320

Merged
fredia merged 1 commit into
apache:masterfrom
Zakelly:f34455
Feb 22, 2024
Merged

[FLINK-34455] Move RestoreMode from flink-runtime to flink-core#24320
fredia merged 1 commit into
apache:masterfrom
Zakelly:f34455

Conversation

@Zakelly

@Zakelly Zakelly commented Feb 18, 2024

Copy link
Copy Markdown
Contributor

What is the purpose of the change

According to the FLIP-406, a new RecoveryOptions class will be introduced in flink-core, which contains options for RestoreMode. Thus the RestoreMode would better be moved to flink-core as well.

Although RestoreMode is @PublicEvolving, there is no public user interface usage of this class (normal user would only use it in configuration), so no breaking change introduced.

Brief change log

  • Move RestoreMode to package org.apache.flink.core.execution
  • Change all imports of RestoreMode

Verifying this change

This change is a trivial rework and is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot

flinkbot commented Feb 18, 2024

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Zakelly

Zakelly commented Feb 18, 2024

Copy link
Copy Markdown
Contributor Author

@flinkbot run azure

1 similar comment
@Zakelly

Zakelly commented Feb 18, 2024

Copy link
Copy Markdown
Contributor Author

@flinkbot run azure

@fredia fredia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zakelly Thanks for the PR, LGTM.

@fredia fredia merged commit 80090c7 into apache:master Feb 22, 2024
@Zakelly Zakelly deleted the f34455 branch February 22, 2024 08:51
@Zakelly

Zakelly commented Feb 22, 2024

Copy link
Copy Markdown
Contributor Author

@fredia Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants